fix: Handle '.geoip_database' index when creating alias #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of Elasticsearch natively include a GeoIP database. The code to set up the convenient 'pelias' Elasticsearch index alias gets tripped up by this, as it wasn't expecting any other indices to exist besides the main Pelias index. We don't want to require people to name their Pelias indices anything specific (though they generally start with `pelias-` according to our project conventions). What we can do is filter out the '.geoip_database' index when creating the alias. Then the first index seen will be a Pelias index.
|
would it make sense to filter any indices starting with a dot? is that some sort of convention they may use again? |
|
agh yeah they're called dot indices: elastic/elasticsearch#50251 |
|
That might make sense. I actually noticed some views in ES 7.16.1 show even more indices, but they are apparently hidden and don't show up in every case. For example, here's a list of shards on a recently set up cluster: |
|
just make sure that regex dot is a dot dot and not a whatever dot! 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of Elasticsearch (somewhere between 7.9 and 7.16) natively include a GeoIP database.
The code to set up the convenient 'pelias' Elasticsearch index alias gets tripped up by this, as it wasn't expecting any other indices to exist besides the main Pelias index.
We don't want to require people to name their Pelias indices anything specific (though they generally start with
pelias-according to our project conventions).What we can do is filter out the '.geoip_database' index when creating the alias. Then the first index seen will be a Pelias index.
This will allow us to support Elasticsearch 7.16.1 to mitigate the log4j security vulnerability pelias/pelias#921