Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude 'dot indices' #25

Merged
merged 1 commit into from
Dec 15, 2021
Merged

fix: exclude 'dot indices' #25

merged 1 commit into from
Dec 15, 2021

Conversation

missinglink
Copy link
Member

"In general, most of the indices that would be considered system indices have
names that start with a . and are referred to as dot indices."

ref: #24

elastic/elasticsearch#50251

"In general, most of the indices that would be considered system indices have
names that start with a . and are referred to as dot indices."

ref: https://github.com/pelias/terraform-elasticsearch/pull/24/commits
@orangejulius
Copy link
Member

Yeah this is better. It's also actually checking for the . character, unlike my previous PR, which I suppose could theoretically match any many index names with 'geoip_databases' in them, as long as there's some single character before the 'g'.

@orangejulius orangejulius merged commit 46420d5 into master Dec 15, 2021
@orangejulius orangejulius deleted the missinglink-patch-1 branch December 15, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants