Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor bundleList and tests to not contact live website #226

Closed
trescube opened this issue May 2, 2017 · 1 comment
Closed

Refactor bundleList and tests to not contact live website #226

trescube opened this issue May 2, 2017 · 1 comment
Labels
good first issue high priority processed

Comments

@trescube
Copy link
Contributor

trescube commented May 2, 2017 •
edited by orangejulius
Loading

The bundleList code contacts WOF for the bundle list. This should be refactored to inject the bundle list URL so that the test can operate offline.
@orangejulius
Copy link
Member

Additionally, it would be great if the bundle URL, and WOF URLs in general, were configurable via pelias.json or environment variable. Using a WOF snapshot could be useful for many instances of pelias that want greater control over the source of their data.

@orangejulius orangejulius mentioned this issue Apr 21, 2020
Closed
Joxit added a commit that referenced this issue Apr 21, 2020
@Joxit
feat(sqlite): drop support for wof bundle
d7f5b51 
BREAKING CHANGE: drop support for wof bundles
BREAKING CHANGE: `imports.whosonfirst.sqlite` default to `true`

fixes #496
fixes #226
closes #460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue high priority processed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orangejulius @trescube