feat(download): Filter out country-specific SQLite DBs #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The country-specific SQLite DBs currently available for download from https://dist.whosonfirst.org have a few integrity issues. This causes problems in Pelias such as addresses in NYC or Berlin not having proper admin information. The planet-wide SQLite DB, while a little out of date, is overall more valid. While in the long term we probably want to utilize the country-specific DBs, for now it makes sense to filter them out. Fixes #469 Connects #460 Fixes #437
orangejulius
force-pushed
the
filter-out-country-sqlite-dbs
branch
from
a3f9b8b
to
6449dcb
Compare
This was referenced Mar 9, 2020
|
We definitely don't want this PR now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The country-specific SQLite DBs currently available for download from https://dist.whosonfirst.org have a few integrity issues. This causes problems in Pelias such as addresses in NYC or Berlin not having proper admin information.
The planet-wide SQLite DB, while a little out of date, is overall more valid.
While in the long term we probably want to utilize the country-specific DBs, for now it makes sense to filter them out.
Fixes #469
Connects #460
Fixes #437