Use 3-character country code for dependencies where possible #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere possible After pelias/api#1622, which extends the `boundary.country` API parameter to include the `depencency` placetype, we noticed that venue and address records often have a 2-character country code when they are part of a dependency. The `boundary.country` parameter currently checks only for 3-character codes, and so the best solution is to ensure the relevant property on all records in Elasticsearch is a 3-character country code whenever possible. This change expands on the logic for selecting an abbreviation for an admin record to be used for point in polygon lookup. Logic specific to countries is expanded to include dependencies, and some additional possible fields that might contain 3-character codes are checked. Because the abbreviaton logic is now a bit more substantial, it's extracted into its own function. It's also been made a bit less redundant and hopefully more clear.
orangejulius
force-pushed
the
dependency-country-code
branch
from
0f6ce72
to
3c68485
Compare
orangejulius
changed the title
orangejulius
added a commit
to pelias/csv-importer
that referenced
this pull request
May 12, 2022
This includes the changes in pelias/wof-admin-lookup#311 that help with using the `boundary.country` API parameter with `dependency` placetypes.
orangejulius
added a commit
to pelias/openstreetmap
that referenced
this pull request
May 16, 2022
This includes the changes in pelias/wof-admin-lookup#311 that help with using the `boundary.country` API parameter with `dependency` placetypes.
orangejulius
added a commit
to pelias/openaddresses
that referenced
this pull request
May 16, 2022
This includes the changes in pelias/wof-admin-lookup#311 that help with using the `boundary.country` API parameter with `dependency` placetypes.
orangejulius
added a commit
to pelias/polylines
that referenced
this pull request
May 16, 2022
This includes the changes in pelias/wof-admin-lookup#311 that help with using the `boundary.country` API parameter with `dependency` placetypes.
This was referenced May 16, 2022
orangejulius
added a commit
to pelias/transit
that referenced
this pull request
May 16, 2022
This includes the changes in pelias/wof-admin-lookup#311 that help with using the `boundary.country` API parameter with `dependency` placetypes.
orangejulius
added a commit
to pelias/pip-service
that referenced
this pull request
May 16, 2022
This includes the changes in pelias/wof-admin-lookup#311 that help with using the `boundary.country` API parameter with `dependency` placetypes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After pelias/api#1622, which extends the
boundary.countryAPI parameter to include thedependencyplacetype, we noticed that venue and address records often have a 2-character country code when they are part of a dependency.The
boundary.countryparameter currently checks only for 3-character codes, and so the best solution is to ensure the relevant property on all records in Elasticsearch is a 3-character country code whenever possible.This change expands on the logic for selecting an abbreviation for an admin record to be used for point in polygon lookup. Logic specific to countries is expanded to include dependencies, and some additional possible fields that might contain 3-character codes are checked.
Because the abbreviation logic is now a bit more substantial, it's extracted into its own function. It's also been made a bit less redundant and hopefully more clear.