Add Last Oasis Egg #2506

CrazyDev05 · 2023-10-12T09:53:25Z

Description

This PR aims to add a Last Oasis Dedicated Server Egg.

Checklist for all submissions

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you tested and reviewed your changes with confidence that everything works?
Did you branch your changes and PR from that branch and not from your master branch?
- If not, why?:

New egg Submissions

Does your submission pass tests (server is connectable)?
Does your egg use a custom docker image?
- Have you tried to use a generic image?
- Did you PR the necessary changes to make it work?
Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
Have you added a unique README.md for the egg you are adding according to the alphabetical order?
You verify that the start command applied does not use a shell script
The egg was exported from the panel

gOOvER · 2023-10-12T10:00:50Z

looks Like my Egg ;)

QuintenQVD0 · 2023-10-12T09:54:46Z

game_eggs/steamcmd_servers/lastoasis/egg-last-oasis.json

+        "pid_limit"
+    ],
+    "docker_images": {
+        "ghcr.io\/parkervcp\/games:source": "ghcr.io\/parkervcp\/games:source"


Please do not use source as this is not a source game, use our new steamcmd debian based image

QuintenQVD0 · 2023-10-12T09:55:21Z

game_eggs/steamcmd_servers/lastoasis/egg-last-oasis.json

+            "default_value": "920720",
+            "user_viewable": false,
+            "user_editable": false,
+            "rules": "required|string|max:20",


use here required|string|in:920720

QuintenQVD0 · 2023-10-12T09:56:48Z

game_eggs/steamcmd_servers/lastoasis/egg-last-oasis.json

+            "name": "[Advanced] Branch Name",
+            "description": "",
+            "env_variable": "SRCDS_BETAID",
+            "default_value": "",


This will not work? as you set that it can be empty but it has to be public or classic

QuintenQVD0 · 2023-10-12T09:57:59Z

game_eggs/steamcmd_servers/lastoasis/egg-last-oasis.json

+    },
+    "scripts": {
+        "installation": {
+            "script": "#!\/bin\/bash\r\n# steamcmd Base Installation Script\r\n#\r\n# Server Files: \/mnt\/server\r\n# Image to install with is 'debian:buster-slim'\r\n\r\n##\r\n#\r\n# Variables\r\n# STEAM_USER, STEAM_PASS, STEAM_AUTH - Steam user setup. If a user has 2fa enabled it will most likely fail due to timeout. Leave blank for anon install.\r\n# WINDOWS_INSTALL - if it's a windows server you want to install set to 1\r\n# SRCDS_APPID - steam app id ffound here - https:\/\/developer.valvesoftware.com\/wiki\/Dedicated_Servers_List\r\n# INSTALL_FLAGS - when a server has extra glas for things like beta installs or updates.\r\n#\r\n##\r\n\r\napt -y update\r\ndpkg --add-architecture i386\r\napt -y update\r\napt -y --no-install-recommends install curl ca-certificates libgcc-s1\r\n\r\n## just in case someone removed the defaults.\r\nif [[ \"${STEAM_USER}\" == \"\" ]] || [[ \"${STEAM_PASS}\" == \"\" ]]; then\r\n    echo -e \"steam user is not set.\\n\"\r\n    echo -e \"Using anonymous user.\\n\"\r\n    STEAM_USER=anonymous\r\n    STEAM_PASS=\"\"\r\n    STEAM_AUTH=\"\"\r\nelse\r\n    echo -e \"user set to ${STEAM_USER}\"\r\nfi\r\n\r\n## download and install steamcmd\r\ncd \/tmp\r\nmkdir -p \/mnt\/server\/steamcmd\r\ncurl -sSL -o steamcmd.tar.gz https:\/\/steamcdn-a.akamaihd.net\/client\/installer\/steamcmd_linux.tar.gz\r\ntar -xzvf steamcmd.tar.gz -C \/mnt\/server\/steamcmd\r\nmkdir -p \/mnt\/server\/steamapps # Fix steamcmd disk write error when this folder is missing\r\ncd \/mnt\/server\/steamcmd\r\n\r\n# SteamCMD fails otherwise for some reason, even running as root.\r\n# This is changed at the end of the install process anyways.\r\nchown -R root:root \/mnt\r\nexport HOME=\/mnt\/server\r\n\r\n## install game using steamcmd\r\n.\/steamcmd.sh +force_install_dir \/mnt\/server +login ${STEAM_USER} ${STEAM_PASS} ${STEAM_AUTH} $( [[ \"${WINDOWS_INSTALL}\" == \"1\" ]] && printf %s '+@sSteamCmdForcePlatformType windows' ) +app_update ${SRCDS_APPID} ${INSTALL_FLAGS} validate +quit ## other flags may be needed depending on install. looking at you cs 1.6\r\n\r\nchmod -R 755 \/mnt\/server\r\n\r\n# Set up 32 and 64 bit libraries\r\nmkdir -p \/mnt\/server\/.steam\/sdk{32,64}\r\ncp -v linux32\/steamclient.so \/mnt\/server\/.steam\/sdk32\/steamclient.so\r\ncp -v linux64\/steamclient.so \/mnt\/server\/.steam\/sdk64\/steamclient.so\r\n\r\n## Fix for Linuxservers\r\nrm -fR $HOME\/Mist\/Binaries\/Linux\/steam_appid.txt\r\ncat <<EOT > $HOME\/Mist\/Binaries\/Linux\/steam_appid.txt\r\n903950\r\nEOT",


Please use our full steamcmd script and not this edited one as with this image package install for example is not needed and then there is an egg to the install when it is done.

and chmod everything to 755 is not needed

and because your script is way out of date it does not even listen to the SRCDS_BETAID variable

QuintenQVD0 · 2023-10-12T10:00:08Z

game_eggs/steamcmd_servers/lastoasis/egg-last-oasis.json

+            "default_value": "5",
+            "user_viewable": true,
+            "user_editable": true,
+            "rules": "required|string|max:100",


make this required to be a number

QuintenQVD0 · 2023-10-12T10:02:56Z

game_eggs/steamcmd_servers/lastoasis/egg-last-oasis.json

+            "default_value": "",
+            "user_viewable": true,
+            "user_editable": true,
+            "rules": "string|nullable|in:public,classic",


you eather set the default to public or just remove the validation or do string|in: ,classic

QuintenQVD0 · 2023-10-12T10:05:00Z

game_eggs/steamcmd_servers/lastoasis/egg-last-oasis.json

+        },
+        {
+            "name": "Provider Key",
+            "description": "You will need to login to \r\n\r\nhttps:\/\/myrealm.lastoasis.gg\/ \r\n\r\nusing Steam, and grab a few keys used for the server setup. Specifically, you will require a CustomerKey, which is used in all servers you\u2019re using on that realm, and a ProviderKey.\r\n\r\nProviderKey can be utilized as many times as you want in as many different servers in the same realm. CustomerKey must be the same across all servers in a realm.",


Please make this a litte shorter and mention it in the readme

QuintenQVD0 · 2023-10-12T10:05:07Z

game_eggs/steamcmd_servers/lastoasis/egg-last-oasis.json

+        },
+        {
+            "name": "Customer Key",
+            "description": "You will need to login to \r\n\r\nhttps:\/\/myrealm.lastoasis.gg\/ \r\n\r\nusing Steam, and grab a few keys used for the server setup. Specifically, you will require a CustomerKey, which is used in all servers you\u2019re using on that realm, and a ProviderKey.\r\n\r\nProviderKey can be utilized as many times as you want in as many different servers in the same realm. CustomerKey must be the same across all servers in a realm.",


QuintenQVD0 · 2023-10-12T10:05:58Z

looks Like my Egg ;)

If it is and he did not confirm with you he can share this then this will be closed ofc

gOOvER · 2023-10-12T10:06:59Z

you took my pr #1548 and only Set you AS dev?

sry, thats a nogo

gOOvER · 2023-10-12T10:07:52Z

looks Like my Egg ;)

If it is and he did not confirm with you he can share this then this will be closed ofc

its my Egg :) He only change the author :)

QuintenQVD0 · 2023-10-12T10:08:39Z

you took my pr #1548 and only Set you AS dev?

sry, thats a nogo

ofc let me handle this

QuintenQVD0 · 2023-10-12T10:09:04Z

@CrazyDev05 We do not tollerate you claiming someone else egg without there permission so this will be closed

CrazyDev05 added 5 commits October 12, 2023 11:41

Create README.md

d2ddbea

Create egg-last-oasis.json

5bcc6a1

Update README.md

de7bb28

Update README.md

660282c

Update README.md

6ee6343

QuintenQVD0 suggested changes Oct 12, 2023

View reviewed changes

QuintenQVD0 closed this Oct 12, 2023

pelican-eggs locked and limited conversation to collaborators Oct 12, 2023

CrazyDev05 deleted the last-oasis branch October 12, 2023 10:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Last Oasis Egg #2506

Add Last Oasis Egg #2506

CrazyDev05 commented Oct 12, 2023 •

edited

Loading

gOOvER commented Oct 12, 2023

QuintenQVD0 Oct 12, 2023

QuintenQVD0 Oct 12, 2023

QuintenQVD0 Oct 12, 2023

QuintenQVD0 Oct 12, 2023

QuintenQVD0 Oct 12, 2023

QuintenQVD0 Oct 12, 2023

QuintenQVD0 Oct 12, 2023

QuintenQVD0 Oct 12, 2023

QuintenQVD0 commented Oct 12, 2023

gOOvER commented Oct 12, 2023

gOOvER commented Oct 12, 2023

QuintenQVD0 commented Oct 12, 2023

QuintenQVD0 commented Oct 12, 2023

Add Last Oasis Egg #2506

Add Last Oasis Egg #2506

Conversation

CrazyDev05 commented Oct 12, 2023 • edited Loading

Description

Checklist for all submissions

New egg Submissions

gOOvER commented Oct 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

QuintenQVD0 commented Oct 12, 2023

gOOvER commented Oct 12, 2023

gOOvER commented Oct 12, 2023

QuintenQVD0 commented Oct 12, 2023

QuintenQVD0 commented Oct 12, 2023

CrazyDev05 commented Oct 12, 2023 •

edited

Loading