The Battle For Wesnoth #237

mattman107 · 2024-04-06T16:18:06Z

Description

Added a yolk for The Battle For Wesnoth game. Needed some specific libraries in the main container to run. I have never used Github actions/workflows before so please let me know if I did something wrong with that.

For this PR: pelican-eggs/eggs#2863 (comment)

All Submissions:

Have you ensured there aren't other open Pull Requests for the same update or change?
Have you created a new branch for your changes and PR from that branch and not from your master branch?

New Image Submissions:

Have you added your image to the Github workflows?
Have you updated the README list to contain your new image?

gOOvER · 2024-04-06T16:26:58Z

games/TheBattleForWesnoth/Dockerfile

+ENV   DEBIAN_FRONTEND noninteractive
+
+## add container user
+RUN   useradd -m -d /home/container -s /bin/bash container


since you are need a user, is this not the correct way?

## Setup user and working directory RUN useradd -m -d /home/container -s /bin/bash container USER container ENV USER=container HOME=/home/container WORKDIR /home/container

Sorry I am new to making containers. So
USER container
this sets what user is logged into right?

And
ENV USER=container HOME=/home/container
These are variables required for pterodactyl to do its thing?

Sorry I am new to making containers. So USER container this sets what user is logged into right?

And ENV USER=container HOME=/home/container These are variables required for pterodactyl to do its thing?

no, you only set the user for the container and the working dir.

Got it. That looking better?

Got it. That looking better?

you deleted the wrong line :)

gOOvER · 2024-04-06T16:51:11Z

games/TheBattleForWesnoth/Dockerfile

@@ -2,10 +2,11 @@ FROM  --platform=$TARGETOS/$TARGETARCH ubuntu:22.04

 LABEL author="Michael Parker" maintainer="parker@pterodactyl.io"

-ENV   DEBIAN_FRONTEND noninteractive


leaves this, but with:

ARG DEBIAN_FRONTEND noninteractive

I think I did this but did I need both lines or just the one you have stated?

ENV DEBIAN_FRONTEND noninteractive
ARG DEBIAN_FRONTEND noninteractive

or just

ARG DEBIAN_FRONTEND noninteractive

README.md

mattman107 · 2024-04-06T20:27:12Z

Forgive me for my ignorance, but I noticed in the games.yml file that it says

runs-on: ubuntu-latest

So I assumed that I had to make the Dockerfile using ubuntu like this

FROM --platform=$TARGETOS/$TARGETARCH ubuntu:22.04

Do I have to use ubuntu or could I use a debian base instead?

QuintenQVD0 · 2024-04-06T21:36:31Z

Forgive me for my ignorance, but I noticed in the games.yml file that it says

runs-on: ubuntu-latest

So I assumed that I had to make the Dockerfile using ubuntu like this

FROM --platform=$TARGETOS/$TARGETARCH ubuntu:22.04

Do I have to use ubuntu or could I use a debian base instead?

Its just what the workflow runs on. But keep in mind that we moved to debian 12 if possible.

mattman107 · 2024-04-06T22:41:01Z

Got it. I will change it to debian then.

make it actually work.

mattman107 · 2024-04-10T02:37:04Z

So I wasn't able to get the github actions working, but I started doing testing manually building the container and uploading it to dockerhub. I have successfully gotten the egg to work properly using the container now in this PR.

mattman107 · 2024-04-18T16:12:06Z

Are any PRs on hold until the whole Pelican restructure situation is figured out?

I have been a bit out of the loop, but really excited to get a chance to it try out.

QuintenQVD0 · 2024-04-18T16:35:25Z

Are any PRs on hold until the whole Pelican restructure situation is figured out?

I have been a bit out of the loop, but really excited to get a chance to it try out.

This repo will become soon read only. All pr must be moved to their individual repo's

mattman107 · 2024-04-18T16:41:51Z

Are any PRs on hold until the whole Pelican restructure situation is figured out?
I have been a bit out of the loop, but really excited to get a chance to it try out.

This repo will become soon read only. All pr must be moved to their individual repo's

Wait so there will no longer be a single unified yolk repository?

In this case where the game requires its own custom docker image to run, what repo would I be making a PR for?

QuintenQVD0 · 2024-04-18T16:43:14Z

Are any PRs on hold until the whole Pelican restructure situation is figured out?
I have been a bit out of the loop, but really excited to get a chance to it try out.

This repo will become soon read only. All pr must be moved to their individual repo's

Wait so there will no longer be a single unified yolk repository?

In this case where the game requires its own custom docker image to run, what repo would I be making a PR for?

Yolks will stay 1 single yolks repo.

mattman107 · 2024-04-18T16:47:42Z

Are any PRs on hold until the whole Pelican restructure situation is figured out?
I have been a bit out of the loop, but really excited to get a chance to it try out.

This repo will become soon read only. All pr must be moved to their individual repo's

Wait so there will no longer be a single unified yolk repository?
In this case where the game requires its own custom docker image to run, what repo would I be making a PR for?

Yolks will stay 1 single yolks repo.

Alright so this PR for the yolk is still in the right place, but the original PR draft for the egg should be moved to the games repo. Am I understanding that correct?

QuintenQVD0 · 2024-04-18T17:22:59Z

Are any PRs on hold until the whole Pelican restructure situation is figured out?
I have been a bit out of the loop, but really excited to get a chance to it try out.

This repo will become soon read only. All pr must be moved to their individual repo's

Wait so there will no longer be a single unified yolk repository?
In this case where the game requires its own custom docker image to run, what repo would I be making a PR for?

Yolks will stay 1 single yolks repo.

Alright so this PR for the yolk is still in the right place, but the original PR draft for the egg should be moved to the games repo. Am I understanding that correct?

yes you are.

QuintenQVD0

LGTM, lets start with this

mattman107 added 4 commits April 6, 2024 11:45

Create Dockerfile

01206f8

Create entrypoint.sh

6608aa0

Update games.yml

60a4041

Update README.md

bc74abe

gOOvER reviewed Apr 6, 2024

View reviewed changes

Update Dockerfile

28a12fe

gOOvER reviewed Apr 6, 2024

View reviewed changes

Update Dockerfile

eb4d129

gOOvER reviewed Apr 6, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

mattman107 added 5 commits April 6, 2024 13:03

Rename Dockerfile to Dockerfile

ac18a5d

Rename entrypoint.sh to entrypoint.sh

e67d10c

Update README.md

c950660

Update games.yml

5fd2ccd

Update README.md

2d562a0

mattman107 closed this Apr 6, 2024

mattman107 deleted the TheBattleOfWesnoth branch April 6, 2024 17:09

mattman107 restored the TheBattleOfWesnoth branch April 6, 2024 17:09

mattman107 reopened this Apr 6, 2024

mattman107 changed the title ~~The Battle of Wesnoth~~ The Battle For Wesnoth Apr 6, 2024

mattman107 added 2 commits April 6, 2024 18:42

Update Dockerfile

bf1f097

Update Dockerfile

691b67d

make it actually work.

mattman107 mentioned this pull request Apr 19, 2024

The Battle for Wesnoth pelican-eggs/games-standalone#1

Open

13 tasks

QuintenQVD0 approved these changes Apr 19, 2024

View reviewed changes

QuintenQVD0 merged commit 3798aba into pelican-eggs:master Apr 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The Battle For Wesnoth #237

The Battle For Wesnoth #237

mattman107 commented Apr 6, 2024 •

edited

Loading

gOOvER Apr 6, 2024

mattman107 Apr 6, 2024

gOOvER Apr 6, 2024

mattman107 Apr 6, 2024

gOOvER Apr 6, 2024 •

edited

Loading

gOOvER Apr 6, 2024

mattman107 Apr 6, 2024 •

edited

Loading

mattman107 commented Apr 6, 2024

QuintenQVD0 commented Apr 6, 2024

mattman107 commented Apr 6, 2024

mattman107 commented Apr 10, 2024 •

edited

Loading

mattman107 commented Apr 18, 2024

QuintenQVD0 commented Apr 18, 2024

mattman107 commented Apr 18, 2024

QuintenQVD0 commented Apr 18, 2024

mattman107 commented Apr 18, 2024 •

edited

Loading

QuintenQVD0 commented Apr 18, 2024

QuintenQVD0 left a comment

		@@ -2,10 +2,11 @@ FROM --platform=$TARGETOS/$TARGETARCH ubuntu:22.04

		LABEL author="Michael Parker" maintainer="parker@pterodactyl.io"

		ENV DEBIAN_FRONTEND noninteractive

The Battle For Wesnoth #237

The Battle For Wesnoth #237

Conversation

mattman107 commented Apr 6, 2024 • edited Loading

Description

All Submissions:

New Image Submissions:

gOOvER Apr 6, 2024

Choose a reason for hiding this comment

mattman107 Apr 6, 2024

Choose a reason for hiding this comment

gOOvER Apr 6, 2024

Choose a reason for hiding this comment

mattman107 Apr 6, 2024

Choose a reason for hiding this comment

gOOvER Apr 6, 2024 • edited Loading

Choose a reason for hiding this comment

gOOvER Apr 6, 2024

Choose a reason for hiding this comment

mattman107 Apr 6, 2024 • edited Loading

Choose a reason for hiding this comment

mattman107 commented Apr 6, 2024

QuintenQVD0 commented Apr 6, 2024

mattman107 commented Apr 6, 2024

mattman107 commented Apr 10, 2024 • edited Loading

mattman107 commented Apr 18, 2024

QuintenQVD0 commented Apr 18, 2024

mattman107 commented Apr 18, 2024

QuintenQVD0 commented Apr 18, 2024

mattman107 commented Apr 18, 2024 • edited Loading

QuintenQVD0 commented Apr 18, 2024

QuintenQVD0 left a comment

Choose a reason for hiding this comment

mattman107 commented Apr 6, 2024 •

edited

Loading

gOOvER Apr 6, 2024 •

edited

Loading

mattman107 Apr 6, 2024 •

edited

Loading

mattman107 commented Apr 10, 2024 •

edited

Loading

mattman107 commented Apr 18, 2024 •

edited

Loading