Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Battle for Wesnoth #1

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

mattman107
Copy link

Description

Egg for The Battle of Wesnoth server. Needs some specific packages to build/run the server binary so a custom yolk has been created. This egg is written assuming this PR will be merged.

Since it currently cannot be run until the yolk is merged and built I will keep this a draft.

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  6. The egg was exported from the panel

@QuintenQVD0 QuintenQVD0 marked this pull request as ready for review April 19, 2024 14:11
@QuintenQVD0
Copy link
Contributor

@mattman107 Please update your fork branch as it is missing to many commits to review / work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants