Initial packaging. #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all articles need subcategories, and yet articles without subcategories produced a critical error.
from next_article to next_article_in_category, next_article_in_subcategory.
As the package has already been released in the wild on PyPi. See: * https://pypi.org/project/pelican-neighbors/1.0.0/ * getpelican/pelican-plugins#1287
|
@justinmayer: this PR is ready to be reviewed! 😃 |
justinmayer
reviewed
Aug 28, 2020
|
I made one small suggestion for a sentence in the README. Otherwise, everything looks great. Well done! 🥇 |
This was referenced Aug 28, 2020
|
Merged to |
|
Thanks @justinmayer for your trust and your incledible fast merging! 👍 |
|
Should we delete the And how about cutting a release to PyPi? I'm ready to test and fix it on my site right now. |
|
Thanks for the reminder. Unneeded branch deleted. Sure, we can add the CI/CD machinery now. It should be a quick step. I'll submit a new branch shortly... |
|
@kdeldycke: PR #3 added in order to get PyPI auto-publication machinery in place. 🕺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package the bare copy of
neighborsplugin into a independent python package, based on:Closes #1.