Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unicode variation selector to arrow character #11

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

MarkoCindric-xyz
Copy link
Contributor

Unicode variation selector U+FE0E forces the arrow character U+21A9 to render as text rather than its corresponding Emoji on iOS.

@justinmayer
Copy link
Contributor

Thank you for the submission, Marko. Do you think we should similarly treat the example arrow character shown in the README? It also shows up as an emoji character when viewing the README on iOS.

@MarkoCindric-xyz
Copy link
Contributor Author

Thanks for catching that, Justin—good call! I'll make the change and include it in this pull request.

For the sake of transparency, this is my first-ever contribution to a public repository, so I hope I'm doing everything correctly and welcome any feedback if not! Thank you for helping to maintain such a helpful plugin. :)

Unicode variation selector U+FE0E forces the arrow character U+21A9 to render as text rather than its corresponding Emoji on iOS. This change is reflected in README.md using the HTML equivalent of the variation selector.
Copy link
Contributor

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your first contribution to a public project repository! 🎉 That's exciting and worthy of recognition. Bravo! 🏅

Many thanks for the enhancement to this plugin. Much appreciated! 😁

@justinmayer justinmayer merged commit fd13a28 into pelican-plugins:main Jun 13, 2024
0 of 2 checks passed
@justinmayer
Copy link
Contributor

The enhancement in this PR was just released in Simple Footnotes 1.0.3 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants