Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Poetry with PDM, Flake8/isort with Ruff #12

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Conversation

justinmayer
Copy link
Contributor

Also fixes a failing test that did not take into account the arrow Unicode specifier that was changed in #11.

@justinmayer
Copy link
Contributor Author

@MarkoCindric-xyz: It seems there was a test that was not updated to reflect the changed Unicode specifier for the arrow character. That test was therefore failing in your pull request, but that failing test was obscured by an unrelated tooling error that I somehow did not notice when I merged the PR. In short, my fault — not yours! 😉

I updated the failing test here to reflect the changed Unicode specifier.

While the continuous integration (CI) system would normally have caught the problem, in the future you can also run the tests locally to catch these kinds of things before submitting the pull request. If you have any questions about how to do that, by all means please let me know. Cheers!

@justinmayer justinmayer merged commit 834cdf7 into main Jun 14, 2024
15 checks passed
@justinmayer justinmayer deleted the pdm-ruff branch June 14, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant