New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding modules for segmentation as performed in cell profiler #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to have those modules! And the wrapping looks good. I have no idea whether that's ok license-wise. Do you know @bebosudo ?
jtlibrary/python/jtmodules/src/jtmodules/segment_secondary_cp.py
Outdated
Show resolved
Hide resolved
jtlibrary/python/jtmodules/src/jtmodules/segment_secondary_cp.py
Outdated
Show resolved
Hide resolved
jtlibrary/python/jtmodules/src/jtmodules/segment_secondary_cp.py
Outdated
Show resolved
Hide resolved
jtlibrary/python/jtmodules/src/jtmodules/segment_secondary_cp.py
Outdated
Show resolved
Hide resolved
jtlibrary/python/jtmodules/src/jtmodules/segment_secondary_cp.py
Outdated
Show resolved
Hide resolved
jtlibrary/python/jtmodules/src/jtmodules/segment_secondary_cp.py
Outdated
Show resolved
Hide resolved
License-wise I've found the following discussion: I think the double license banner that Scott used is fine. The only missing bit would be to mention the fact that part of the code is double-licensed in the sub-project README: If you could add a couple of lines in a LICENSE.txt file in the main repo, indicating that there are several projects in this repo, and to refer to the different licenses, it would be great! |
Co-authored-by: Alberto Chiusole <1922124+bebosudo@users.noreply.github.com>
Co-authored-by: Alberto Chiusole <1922124+bebosudo@users.noreply.github.com>
Co-authored-by: Alberto Chiusole <1922124+bebosudo@users.noreply.github.com>
Co-authored-by: Alberto Chiusole <1922124+bebosudo@users.noreply.github.com>
Co-authored-by: Alberto Chiusole <1922124+bebosudo@users.noreply.github.com>
Co-authored-by: Alberto Chiusole <1922124+bebosudo@users.noreply.github.com>
@bebosudo would you be able to add the licence info to jtlibrary README.txt for me? |
Sure, I'll do. |
I developed these a while ago based on the CellProfiler segmentation modules but they seem to not be in the main repository. They work in my hands but I can't remember if there are some additional python dependencies that need to be installed. The only issue here is licensing, which I am not sure about. I just copied in the BSD 3-Clause License I found on the CellProfiler code