Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding modules for segmentation as performed in cell profiler #7

Merged
merged 7 commits into from Jul 7, 2020

Conversation

scottberry
Copy link

I developed these a while ago based on the CellProfiler segmentation modules but they seem to not be in the main repository. They work in my hands but I can't remember if there are some additional python dependencies that need to be installed. The only issue here is licensing, which I am not sure about. I just copied in the BSD 3-Clause License I found on the CellProfiler code

Copy link

@jluethi jluethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have those modules! And the wrapping looks good. I have no idea whether that's ok license-wise. Do you know @bebosudo ?

@bebosudo
Copy link

License-wise I've found the following discussion:
https://opensource.stackexchange.com/questions/8107/distributing-bsd-3-code-under-the-apache-license-v2-only

I think the double license banner that Scott used is fine.
@scottberry: if you could link to the precise original commit you copied the code from it could be great.

The only missing bit would be to mention the fact that part of the code is double-licensed in the sub-project README:
https://github.com/pelkmanslab/TissueMAPS/blob/master/jtlibrary/LICENSE.txt

If you could add a couple of lines in a LICENSE.txt file in the main repo, indicating that there are several projects in this repo, and to refer to the different licenses, it would be great!

scottberry and others added 6 commits July 7, 2020 16:41
Co-authored-by: Alberto Chiusole <1922124+bebosudo@users.noreply.github.com>
Co-authored-by: Alberto Chiusole <1922124+bebosudo@users.noreply.github.com>
Co-authored-by: Alberto Chiusole <1922124+bebosudo@users.noreply.github.com>
Co-authored-by: Alberto Chiusole <1922124+bebosudo@users.noreply.github.com>
Co-authored-by: Alberto Chiusole <1922124+bebosudo@users.noreply.github.com>
Co-authored-by: Alberto Chiusole <1922124+bebosudo@users.noreply.github.com>
@scottberry scottberry merged commit e889aed into master Jul 7, 2020
@bebosudo bebosudo deleted the cellprofiler_segmentation branch July 7, 2020 14:46
@scottberry
Copy link
Author

@bebosudo would you be able to add the licence info to jtlibrary README.txt for me?

@bebosudo
Copy link

bebosudo commented Jul 7, 2020

Sure, I'll do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants