Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the prefix setting #19

Closed
ErinCall opened this issue Dec 18, 2019 · 1 comment · Fixed by #32
Closed

Implement the prefix setting #19

ErinCall opened this issue Dec 18, 2019 · 1 comment · Fixed by #32
Assignees
@ErinCall
Labels
drone-helm parity Feature parity with drone-helm enhancement New feature or request
Milestone
Version 1.0

Comments

@ErinCall
Copy link
Contributor

drone-helm allows the drone chart to set a prefix to be used when looking up environment variables. For example, given this stanza:

environment:
  prefix: FOO
  foo_token: fjejkdkfjfj

It will look for the token setting in FOO_TOKEN rather than TOKEN.

We should retain support for that feature.
@ErinCall ErinCall added enhancement New feature or request drone-helm parity Feature parity with drone-helm labels Dec 18, 2019
@ErinCall ErinCall added this to the Version 1.0 milestone Dec 18, 2019
@ErinCall
Copy link
Contributor Author

ErinCall commented Dec 18, 2019 •
edited
Loading

Relates to the “let all settings omit the PLUGIN_ prefix” change proposed in #9.

ErinCall added a commit that referenced this issue Dec 24, 2019
@ErinCall
Allow a configurable env var prefix [#19]
285e9d9 
I'd like to keep Prefix's scope fairly limited, because it has potential
to spiral into something magnificently complex. You get one prefix
setting, it goes in `settings` not `environment`, end of feature.
@ErinCall ErinCall mentioned this issue Dec 24, 2019
Merged
ErinCall added a commit that referenced this issue Dec 24, 2019
@ErinCall
Document the Config struct's behavior correctly [#19] [#9]
10e7e7f
@ErinCall ErinCall mentioned this issue Dec 24, 2019
Closed
@ErinCall ErinCall self-assigned this Dec 24, 2019
ErinCall added a commit that referenced this issue Dec 30, 2019
@ErinCall
The prefix setting is implemented [#19,#9]
22e30fe 
Just something I noticed while resolving a merge conflict. The "write
some docs" and "implement prefix" branches happened concurrently and
didn't get re-coordinated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErinCall ErinCall

Labels
drone-helm parity Feature parity with drone-helm enhancement New feature or request
Projects
None yet
Milestone
Version 1.0
Development

Successfully merging a pull request may close this issue.

Clarify and improve internal/helm.Config pelotech/drone-helm3
1 participant
@ErinCall