Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type accessors #38

Merged
merged 7 commits into from
May 10, 2018
Merged

Fix type accessors #38

merged 7 commits into from
May 10, 2018

Conversation

sledorze
Copy link
Contributor

@sledorze sledorze commented May 9, 2018

Fixes #34.

@coveralls
Copy link

coveralls commented May 9, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 22321f7 on sledorze:34 into 9be48a4 on pelotom:master.

@sledorze sledorze mentioned this pull request May 9, 2018
package.json Outdated
"js",
"ts"
],
"moduleFileExtensions": ["js", "ts"],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is nothing but formatting, can you revert this change? I need to add package.json to .prettierignore.

@sledorze
Copy link
Contributor Author

@pelotom done!

.prettierignore Outdated
@@ -1,3 +1,4 @@
lib
coverage
README.md
package.json
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already done on master.

@pelotom pelotom changed the title Rework types to allow type accessors - fixes 34 Fix type accessors May 10, 2018
@sledorze
Copy link
Contributor Author

done

@pelotom pelotom merged commit 479f98d into pelotom:master May 10, 2018
@pelotom
Copy link
Owner

pelotom commented May 10, 2018

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants