Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with common substring detection #22

Closed
pemistahl opened this issue Apr 6, 2020 · 0 comments
Closed

Problem with common substring detection #22

pemistahl opened this issue Apr 6, 2020 · 0 comments
Labels
bug Something isn't working
Milestone
grex 1.1.0

Comments

@pemistahl
Copy link
Owner

There is a bug in the common substring detection algorithm causing union operations to be applied where optionality expressions would be more appropriate. The resulting regex is not incorrect but more complex than necessary. Examples:

Test Cases Expected Actual
ac abc ^ab?c$ ^a(bc|c)$
abc abxyc ^ab(xy)?c$ ^ab(xyc|c)$
@pemistahl pemistahl added the bug Something isn't working label Apr 6, 2020
@pemistahl pemistahl added this to the grex 1.1.0 milestone Apr 6, 2020
pemistahl added a commit that referenced this issue Apr 6, 2020
@pemistahl
Fix problem in common substring detection algorithm (#22)
5b272c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
grex 1.1.0
Development

No branches or pull requests
1 participant
@pemistahl