Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position propagation #805

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Fix position propagation #805

merged 3 commits into from
Mar 2, 2022

Conversation

raviqqe
Copy link
Contributor

@raviqqe raviqqe commented Mar 2, 2022

Close #645.

@raviqqe raviqqe added the merge label Mar 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #805 (95914d5) into main (a598620) will decrease coverage by 0.09%.
The diff coverage is 35.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #805      +/-   ##
==========================================
- Coverage   85.41%   85.32%   -0.10%     
==========================================
  Files         317      317              
  Lines       29466    29519      +53     
==========================================
+ Hits        25168    25186      +18     
- Misses       4298     4333      +35     
Impacted Files Coverage Δ
lib/hir/src/types/boolean.rs 63.63% <0.00%> (-36.37%) ⬇️
lib/hir/src/types/byte_string.rs 36.36% <0.00%> (-20.78%) ⬇️
lib/hir/src/types/function.rs 80.95% <0.00%> (-19.05%) ⬇️
lib/hir/src/types/list.rs 76.47% <0.00%> (-23.53%) ⬇️
lib/hir/src/types/none.rs 63.63% <0.00%> (-36.37%) ⬇️
lib/hir/src/types/reference.rs 76.47% <0.00%> (-23.53%) ⬇️
lib/hir/src/types/union.rs 80.95% <0.00%> (-19.05%) ⬇️
lib/hir/src/types/type_.rs 82.22% <46.15%> (-6.09%) ⬇️
lib/hir/src/analysis/types/type_canonicalizer.rs 99.57% <50.00%> (ø)
lib/hir/src/analysis/types/type_resolver.rs 92.30% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a598620...95914d5. Read the comment docs.

@mergify mergify bot merged commit 6500353 into main Mar 2, 2022
@mergify mergify bot deleted the chore/position-prop branch March 2, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix position propagation in hir-mir crate
2 participants