Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom shortcut not working with the mouse #1189

Open
scribblemaniac opened this Issue Mar 9, 2019 · 7 comments

Comments

Projects
None yet
3 participants
@scribblemaniac
Copy link
Member

scribblemaniac commented Mar 9, 2019

Issue Summary

The control+drag shortcut for zooming does not appear to be working for me.

Actual Results

Holding control and dragging with the left mouse button freezes the canvas cursor at point where the dragging started, and the canvas does not resize. The canvas cursor does not update until the first movement after release. Control+dragging with a tablet works correctly.

Expected Results

Holding control and dragging with the mouse should zoom the canvas in or out.

Steps to reproduce

  1. Hold control
  2. Left click and drag

System Information

  • Pencil2D Version: e4e7d1a nightly build or v0.6.2 build from source

  • Operating System: macOS 10.13.6

  • RAM Size: 16 GB

  • Qt Version: 5.12.1


Technical Details

I'm assuming this is macOS only since @Jose-Moreno has been using this with the latest nightlies. After a little bit of testing, I have determined that ScribbleArea::mouseMoveEvent and ScribbleArea::mouseReleaseEvent are not getting called at all when the control button is held. ScribbleArea::mousePressEvent is called as expected. This could be because control+click has a default behavior on mac of opening the context menu.

The shortcut works with the v0.6.2 build, however it does not work when I build that tag manually, which suggests that this is almost certainly a Qt 5.12 issue.

@davidlamhauge

This comment has been minimized.

Copy link
Contributor

davidlamhauge commented Mar 9, 2019

What you write @scribblemaniac, is that implicit that you have selected the hand-tool?
Maybe it's a stupid question, but here, on Ubuntu, Ctrl-Drag only works when the hand tool is selected. I've never used that feature before. Didn't know it existed.

@scribblemaniac

This comment has been minimized.

Copy link
Member Author

scribblemaniac commented Mar 9, 2019

@davidlamhauge No actually, it should work with all tools. I also just recently found out about it too. Have you tested with a version build with qt <5.12 (ex. the v0.6.2 build)?

@Jose-Moreno

This comment has been minimized.

Copy link
Member

Jose-Moreno commented Mar 10, 2019

The plot thickens and the rabbit hole gets deeper. Indeed I'm not having such issues on Windows. Ctrl + MMB or RMB + Drag work as expected. Would have to test on Linux as well though considering David mentions that it's not working for him 😩

@scribblemaniac

This comment has been minimized.

Copy link
Member Author

scribblemaniac commented Mar 10, 2019

Hmm, actually Control+RMB works for me but not Control+LMB or MMB.

@Jose-Moreno

This comment has been minimized.

Copy link
Member

Jose-Moreno commented Mar 10, 2019

If you have quick-sizing enabled Ctrl+LMB will forcefully try to change the feathering of any given tool. If it's disabled, it shouldn't work either or at least It never has for me; only MMB / RMB. Since I come from Blender land we use MMB for everything so I'm used to that; I never thought about what should be the correct key combination to use to be honest 🤔

@davidlamhauge

This comment has been minimized.

Copy link
Contributor

davidlamhauge commented Mar 10, 2019

After a good nights sleep, I've tested it again. It's Ubuntu 18.04, Qt Creator 4.8.2, based on Qt 5.12.1.
Ctrl+LMB only works with the Hand tool selected.
Ctrl+RMB works all the time.
Ctrl+MMB works all the time, but in a buggy way. Sometimes it jumps to 1% when I start dragging, but it is not consistent.

@Jose-Moreno

This comment has been minimized.

Copy link
Member

Jose-Moreno commented Mar 17, 2019

I'm having the same issues for MMB on Windows 7 Ultimate as David describes. MMB is consistently broken when using the navigation modifiers on drawing tools. The best way to quickly test it is by pressing CTRL + H, pressing MMB and move it slightly. The reproduction behavior is similar to the other bug report that was closed at #1169 but only with MMB.

Edit: Also tested with the Hand tool, it has similar issues, only with MMB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.