Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/minor export issues #1123

Merged
merged 11 commits into from
Dec 4, 2018
Merged

Fix/minor export issues #1123

merged 11 commits into from
Dec 4, 2018

Commits on Oct 26, 2018

  1. Transparency check box disappears for JPG. 

    Initial commit, with logic in the formatChanged "slot", just to check
that this is indeed the right place for it.
    @przet
    przet committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    2c073b5 View commit details
    Browse the repository at this point in the history

  2. Wrote function to hold transparency option logic. 

    The function is private in the exportimagedialog class.
    @przet
    przet committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    6af6c23 View commit details
    Browse the repository at this point in the history

  3. Fixed a comment. 

    Was meant to be OR (||) not AND (&&)
    @przet
    przet committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    0cd4bed View commit details
    Browse the repository at this point in the history

  4. Disabled Transparency export for BMP. 

    After a look around at exporting BMP with transparency, decided
to remove the option for the moment, with the view of opening another
issue with just this, if the maintainers are happy with that.
    @przet
    przet committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    3bfe690 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2018

  1. Fixed error of ignoring . in filename. 

    If you want to name something frame.test.extension, this now works with
only extension changing now.
    @przet
    przet committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    643a370 View commit details
    Browse the repository at this point in the history

  2. Multiframe bmp saving consistent with other format.

    @przet
    przet committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    027650f View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2018

  1. Merge upstream 'master' into fix/minor_export_issues

    @przet
    przet committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    01efb17 View commit details
    Browse the repository at this point in the history

  2. Removed comments. 

    These were comments made for development
    @przet
    przet committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    ed43151 View commit details
    Browse the repository at this point in the history

  3. Typo fix. 

    Co-Authored-By: przet <przet@tpg.com.au>
    @candyface @przet
    candyface and przet committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    160a577 View commit details
    Browse the repository at this point in the history

  4. Typo fix. 

    Co-Authored-By: przet <przet@tpg.com.au>
    @candyface @przet
    candyface and przet committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    9e3e55d View commit details
    Browse the repository at this point in the history

  5. Typo fix. 

    Co-Authored-By: przet <przet@tpg.com.au>
    @candyface @przet
    candyface and przet committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    cfb1f8a View commit details
    Browse the repository at this point in the history