Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more crashes when there is no previous frame #1388

Merged
merged 3 commits into from Jun 19, 2020

Commits on Jun 14, 2020

  1. Check for null pointer returned by getLastVectorImageAtFrame where re…

    …levant
    
    There are places that only have a Q_CHECK_PTR because they
    follow a call to ScribbleArea::handleDrawingOnEmptyFrame which
    should guarantee a frame after invocation. However this is called only
    at the start of a stroke typically, which means that if the frame is
    deleted while the stroke is in progress (ex. with a shortcut), then
    it will still crash without a check. Users who aren't trying to break
    the program will likely never do this, but we might as well add the
    checks if we know the issue is there.
    scribblemaniac committed Jun 14, 2020
    Copy the full SHA
    f61b6ad View commit details
    Browse the repository at this point in the history
  2. Check for null pointer returned by getLastBitmapImageAtFrame where re…

    …levant
    
    See commit message of f61b6ad. This is the same thing execpt for
    bitmaps.
    scribblemaniac committed Jun 14, 2020
    Copy the full SHA
    8af591e View commit details
    Browse the repository at this point in the history
  3. Fix unhandled cases where LastFrameAtFrame returns -1

    This was causing crashes when there were no previous frames on any
    layer.
    scribblemaniac committed Jun 14, 2020
    Copy the full SHA
    b58207e View commit details
    Browse the repository at this point in the history