Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue that can cause pencilblue crashing when there is an uns… #1233

Merged
merged 1 commit into from
Feb 23, 2017
Merged

Fix the issue that can cause pencilblue crashing when there is an uns… #1233

merged 1 commit into from
Feb 23, 2017

Conversation

vunguyen-it
Copy link

@vunguyen-it vunguyen-it commented Feb 23, 2017 •
edited
Loading

…upported media in the client editor

Fixes #

  • Unit tests created and pass
  • JS Docs have been updated

Description:
Fix the issue that can cause Pencilblue crashing when there is an unsupported media in the client editor

To reproduce issue:

  • Go to Pencilblue admin
  • Go to pages
  • Create a page
  • Insert a none exist media (can be an image that deleted) to the editor

@pencilblue/owners

@coveralls
Copy link

coveralls commented Feb 23, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 35.249% when pulling 6dbf572 on tuanvu89:fix_get_media_embed_api into 5575854 on pencilblue:master.

@brianhyder brianhyder added the bug label Feb 23, 2017
@brianhyder brianhyder added this to the 0.8.1 milestone Feb 23, 2017
@brianhyder brianhyder merged commit 24d9379 into pencilblue:master Feb 23, 2017
@vunguyen-it vunguyen-it deleted the fix_get_media_embed_api branch February 24, 2017 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakecallens blakecallens Awaiting requested review from blakecallens

@brianhyder brianhyder Awaiting requested review from brianhyder

Assignees

@vunguyen-it vunguyen-it

Labels
bug
Projects
None yet
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@vunguyen-it @coveralls @brianhyder