Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated version from 2015 to 2018 #1

Merged
merged 7 commits into from
Sep 27, 2020
Merged

updated version from 2015 to 2018 #1

merged 7 commits into from
Sep 27, 2020

Conversation

MathisWellmann
Copy link
Contributor

using Rust version 2018 and fixed the resulting errors, no logical changes to the library just refactoring

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@pengowen123
Copy link
Owner

Thanks for the contribution! I noticed a few small things, but overall this looks good 👍

@MathisWellmann
Copy link
Contributor Author

Thanks for actively looking at my PR. I'm rather new to creating pull request to other repos and originally only intended to merge the first two commits but apparently once I added more commits to my own fork it shows up here as well. regardless I kind of like all the commits as it pretty much just extends the Activation enum to more functions and provides useful methods. With the last commit I resolved your suggestions and it should hopefully be ready to merge.

@pengowen123 pengowen123 merged commit a33a320 into pengowen123:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants