Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

支持设置指定时间点挂号 #74

Merged
merged 7 commits into from
Aug 2, 2024
Merged

支持设置指定时间点挂号 #74

merged 7 commits into from
Aug 2, 2024

Conversation

weimo123
Copy link
Contributor

@weimo123 weimo123 commented Aug 1, 2024

No description provided.

@weimo123
Copy link
Contributor Author

weimo123 commented Aug 2, 2024

image
昨晚跑着就出异常了,感觉不太是我改的代码导致的

@pengpan
Copy link
Owner

pengpan commented Aug 2, 2024

image 昨晚跑着就出异常了,感觉不太是我改的代码导致的

看起来应该是登录失败
image
可以这里做下重试

@weimo123
Copy link
Contributor Author

weimo123 commented Aug 2, 2024

image 昨晚跑着就出异常了,感觉不太是我改的代码导致的

看起来应该是登录失败 image 可以这里做下重试

@pengpan 已增加重试机制
image

@pengpan
Copy link
Owner

pengpan commented Aug 2, 2024

看下那个排序问题,我试了下是有问题的

@weimo123
Copy link
Contributor Author

weimo123 commented Aug 2, 2024

看下那个排序问题,我试了下是有问题的

确实,之前的是基于一个时间段的数据排序,改为基于全部数据排序了

if (CollUtil.isNotEmpty(config.getHours())) {
appointmentList = appointmentList.stream()
.filter(x -> config.getHours().contains(x.getName()))
.sorted(Comparator.comparingInt(x -> config.getHours().indexOf(x.getName())))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

排序有问题

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果是正序,直接.sorted(Comparator.comparing(Appointment::getName))即可

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多谢指导,再搞个indexOf有点多此一举了

@pengpan pengpan merged commit d5d2506 into pengpan:main Aug 2, 2024
@pengpan
Copy link
Owner

pengpan commented Aug 5, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants