Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrongly encoded character in translator name #2017

Closed
wants to merge 1 commit into from

Conversation

larjona
Copy link

@larjona larjona commented May 4, 2018

Hello, a translator name appearing in several .po files includes a character wrongly encoded.
I have joined the Transifex Spanish team in django-allauth project with the hope of being able to contact this person so they fix their name in Transifex, but I'm not accepted yet, and I am not sure if I can contact there either. The .po files do not include email or contact info for this person.
So I propose to fix the string directly in the .po files, with the hope that those are not overwritten in future dumps from Transifex, until the translator is contacted.

Thanks!

@P-EB
Copy link

P-EB commented May 4, 2018

Would close issue #1910.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.251% when pulling 693ca35 on larjona:master into 2e66e00 on pennersr:master.

1 similar comment
@coveralls
Copy link

coveralls commented May 4, 2018

Coverage Status

Coverage remained the same at 94.251% when pulling 693ca35 on larjona:master into 2e66e00 on pennersr:master.

@larjona
Copy link
Author

larjona commented May 11, 2018

Hello
My request to join the django-allauth translation team in Transifex has been approved and I've been able to check the affected .po files in Transifex. All of them now have an updated "Last translator" or the name of the translator with no bad encoding character. So instead of merging my pull request, updating the git repo retrieving the last translation from Transifex would fix the issue too.
I will close my merge request now.

Thanks!

@larjona larjona closed this May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants