Add ACCOUNT_LOGOUT_ON_PASSWORD_CHANGE setting #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,6 +58,11 @@ ACCOUNT_LOGOUT_ON_GET (=False) | |||
| mere GET request. See documentation for the `LogoutView` for | |||
| details. | |||
|
|
|||
| ACCOUNT_LOGOUT_ON_PASSWORD_CHANGE (=False) | |||
| Determines whether or not the user is automatically logged out after | |||
| changing the password. See documentation for `Django's session invalidation on password change` | |||
There was a problem hiding this comment.
Nit: mind the line wrapping. It'd also help to link to Django docs on the topic.
|
This looks good cc @pennersr. |
pennersr
added a commit
that referenced
this pull request
Jun 3, 2015
Add ACCOUNT_LOGOUT_ON_PASSWORD_CHANGE setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Django 1.7, if the SessionAuthenticationMiddleware is enabled, the session is invalidated when the user changes the account's password.
Starting Django 2.0, session verification will become mandatory whether or not the SessionAuthenticationMiddleware is enabled.
I figured this may be a good time to add this setting.
Source: Session invalidation on password change