Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NodeNext support #25

Merged
merged 2 commits into from
Jun 4, 2023
Merged

Add NodeNext support #25

merged 2 commits into from
Jun 4, 2023

Conversation

akiomik
Copy link
Contributor

@akiomik akiomik commented Jun 4, 2023 •
edited

Fixed the following error that occurred when using rx-nostr in a project where "moduleResolution": "NodeNext" is specified in tsconfig.json.

TS7016: Could not find a declaration file for module 'rx-nostr'. '/Users/akiomi/src/github.com/akiomik/sample-project/node_modules/rx-nostr/dist/index.es.js' implicitly has an 'any' type.
  There are types at '/Users/akiomi/src/github.com/akiomik/sample-project/node_modules/rx-nostr/types/src/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'rx-nostr' library may need to update its package.json or typings.

ESM support for Jest is based on the following page.

@penpenpng penpenpng self-requested a review June 4, 2023 16:58
penpenpng
penpenpng approved these changes Jun 4, 2023
View reviewed changes
Copy link
Owner

@penpenpng penpenpng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@penpenpng penpenpng merged commit 8d60d06 into penpenpng:main Jun 4, 2023
1 check passed
@penpenpng penpenpng mentioned this pull request Jun 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penpenpng penpenpng penpenpng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akiomik @penpenpng