Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pick color position of some fonts is offset #1049

Closed
soultipsy opened this issue Jun 18, 2021 · 1 comment · Fixed by #1075
Closed

The pick color position of some fonts is offset #1049

soultipsy opened this issue Jun 18, 2021 · 1 comment · Fixed by #1075
Assignees
Labels
bug managed on taiga This issue has been moved to our project at Taiga.io
Milestone

Comments

@soultipsy
Copy link
Contributor

Describe the bug
When taking a color for some fonts, such as Noto Sans SC or Source Sans Pro, the color picker does not pick up the actual position of the color, resulting in an inaccurate pick up color. This may be related to the font baseline position and height.(Noto Sans and Source Sans belong to the same family, I guess all fonts in this family have this problem).

To Reproduce
Steps to reproduce the behavior:

  1. Turn on the color picker
  2. Pick color for Source Sans font family
  3. The position and color of the color picker preview window are not consistent with the position and color pointed by the actual cursor

Expected behavior
The position of the color in the preview window should be the same as that of the cursor

Screenshots
Screenshots show that the first two fonts do not deviate like the Sources Sans family of fonts.

2021-06-18-12-47-34.mp4

Desktop (please complete the following information):

  • OS: Windows
  • Browser : Firefox&Microsoft Edge
  • Version :89.0&92.0.902.15 Beta

Environment (please complete the following information):
SAAS (https://design.penpot.app)

@soultipsy soultipsy added the bug label Jun 18, 2021
@myfunnyandy
Copy link
Contributor

We've opened an issue at Taiga, thanks for the report: #1049

@myfunnyandy myfunnyandy added the managed on taiga This issue has been moved to our project at Taiga.io label Jun 21, 2021
@Alotor Alotor self-assigned this Jul 7, 2021
@Alotor Alotor added this to the 1.7.0 milestone Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug managed on taiga This issue has been moved to our project at Taiga.io
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants