feature: Hide bounding-box when editing shape. #3930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VasilevsVV
changed the title
|
Hi @VasilevsVV Thank you very much for your contribution. I have finally been able to have quality time for this PR. I have squashed commits with small modifications and replaced your PR with this one: I also formatted the commit message according to the https://github.com/penpot/penpot/blob/develop/CONTRIBUTING.md guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3232
Added behavior for hiding bounding-box of shapes. As described in: #3232
Bounding box (
bb) is being hidden for 1 sec, after any changes in sidebar->measures, made "by hand".Realized via new flag for shape, indicating it being transformed.
Also: scheduling an updateEvent (
task) to set shape'sbbvisible after 1 sec.This
taskschedule resets after each trigger of event, making surebbisn't flickering.