[hyperbolic] Fixed bug: stop optimization if max iter OR eps criteria is

met
penrose · Sep 9, 2020 · 647ed05 · 647ed05
1 parent 011275d
commit 647ed05
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/react-renderer/src/Optimizer.ts b/react-renderer/src/Optimizer.ts
@@ -542,11 +542,15 @@ export const minimizeTF = (
   let gradfx;
   let vals;
 
-  while ((i < maxSteps) || (sc(normGrad) > EPS)) {
+  while( 1 ) {
     energy = optimizer.minimize(() => f(...xs) as any, true);
     gradfx = gradf(xs);
     normGrad = tf.stack(gradfx).norm();
 
+    if( i >= maxSteps || (sc(normGrad) < EPS) ) {
+       break;
+    }
+
     // note: this printing could tank the performance
     if (DEBUG_OPT) {
       vals = xs.map(v => v.dataSync()[0]);