feat: resolve image paths in @penrose/editor
#1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1018 +/- ##
==========================================
+ Coverage 63.48% 63.49% +0.01%
==========================================
Files 62 62
Lines 7936 7939 +3
Branches 1803 1802 -1
==========================================
+ Hits 5038 5041 +3
Misses 2782 2782
Partials 116 116
Continue to review full report at Codecov.
|
Deploying with
|
| Latest commit: |
53bc6a7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a46cc76a.penrose-72l.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue/PR: #1000
This PR adds support for Style-included images for (1)
rogerlocal development mode and (2) the example registry. We assume that image paths in Style are relative to the Style file parent directory, and they are all relative paths, not absolute ones.First,
WorkspaceLocationnow keeps necessary data for file path resolution. Then for (1), we send aretrieve_file_from_stylepacket via the websocket connection (now a part ofRogerStatemanaged by Recoil), and resolve the image onfile_changeresponse with the same token. For (2), we keep track of the directory that the Style program is in and construct the URL for the image by callingnew URL.Checklist
diagrams/folderOpen questions
rogerwill not perform HTTP requests and only does local file fetching