-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Walk on spheres #1022
feat: Walk on spheres #1022
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1022 +/- ##
=======================================
Coverage 64.14% 64.14%
=======================================
Files 62 62
Lines 7945 7945
Branches 1802 1802
=======================================
Hits 5096 5096
Misses 2733 2733
Partials 116 116 Continue to review full report at Codecov.
|
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incredible, thanks so much for making this @keenancrane! Possibly our most compelling Penrose example yet.
@@ -0,0 +1,22 @@ | |||
type Domain -- a region in ℝⁿ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unicode, nice 😎
Step x0, x1, x2, x3, x4 | ||
|
||
x1 := sampleBoundary( x0 ) | ||
x2 := sampleBoundary( x1 ) | ||
x3 := sampleBoundary( x2 ) | ||
x4 := sampleBoundary( x3 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a matter of aesthetics, but could we do this instead? (same for the other .sub
files in this directory)
Step x0, x1, x2, x3, x4 | |
x1 := sampleBoundary( x0 ) | |
x2 := sampleBoundary( x1 ) | |
x3 := sampleBoundary( x2 ) | |
x4 := sampleBoundary( x3 ) | |
Step x0 | |
Step x1 := sampleBoundary( x0 ) | |
Step x2 := sampleBoundary( x1 ) | |
Step x3 := sampleBoundary( x2 ) | |
Step x4 := sampleBoundary( x3 ) |
@samestep I think we should merge this now. I don't think your comment is significant enough to delay. |
@samestep Yeah, I can see an argument for that coding style also. I think ultimately how this should look is some kind of array syntax:
Of course, that doesn't exist yet! It may also be useful for people to see that declaring all your variables up front is possible as one way to write Substance code. So, I'm gonna leave it for now… (and squash/merge). Thanks! |
This PR adds a new example
walk-on-spheres
. See the README for details.