fix: issue #1024 exclude name, ensureOnCavas in SVG #1025
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #1024
This year we added svg-passthrough functionality, which allows unknown properties to be passed through to the SVG output. Around this time, we also renamed most internal Style properties to correspond with the SVG names so most properties could flow right through the renderer into the SVG. This approach eliminated code and make life easier for the Style developer who happens to already be familiar with SVG.
The tradeoff is that we sometimes have properties that are purely internal that we do not want to "leak" into the SVG. This is implemented as an exclusion list in AttrHelper.ts. Issue #1024 observes leakage of two internal-only properties,
name
andensureOnCanvas
. This PR adds these two properties to the exclusion list to elide them from the SVG output.Implementation strategy and design decisions
Updated exclusion list in AttrHelper.ts. Updated the rendered diagram set, which now lacks the
name
andensureOnCanvas
properties in the SVG output. This diagram set is the current means by which we catch unintended changes to rendered properties.Checklist
diagrams/
folder