Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add debug mode setting to @penrose/editor #1030

Merged
merged 2 commits into from
May 28, 2022
Merged

feat: add debug mode setting to @penrose/editor #1030

merged 2 commits into from
May 28, 2022

Conversation

wodeni
Copy link
Member

@wodeni wodeni commented May 27, 2022

Description

@penrose/editor current displays the debug tabs on the right regardless if it's in production or development mode. This PR adds an explicit "debug mode" checkbox in the "settings" tab. This option is on by default in local dev mode and off in production. Currently, checking this box will display the debug tabs on the right:

image

Un-checking it hides them:

image

If the user drags one of the tabs out of the right tab group, unchecking the box will not hide it. Not sure if it's a bug or feature:

image

Implementation strategy and design decisions

  • Added a flag in Settings
  • Added a onSet effect for hiding/showing the right border group

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated changes to the diagrams/ folder

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 27, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 97eb4fa
Status: ✅  Deploy successful!
Preview URL: https://679250f4.penrose-72l.pages.dev

View logs

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1030 (97eb4fa) into main (5863147) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1030   +/-   ##
=======================================
  Coverage   64.18%   64.18%           
=======================================
  Files          62       62           
  Lines        7954     7954           
  Branches     1802     1802           
=======================================
  Hits         5105     5105           
  Misses       2733     2733           
  Partials      116      116           
Impacted Files Coverage Δ
packages/core/src/utils/Error.ts 34.72% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5863147...97eb4fa. Read the comment docs.

@maxkrieger
Copy link
Member

Code LGTM!

@wodeni wodeni merged commit d9c5485 into main May 28, 2022
@wodeni wodeni deleted the ide-debug-mode branch May 28, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants