-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add Support for images with absolute URLs #1033
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1033 +/- ##
=======================================
Coverage 64.18% 64.18%
=======================================
Files 62 62
Lines 7954 7954
Branches 1802 1802
=======================================
Hits 5105 5105
Misses 2733 2733
Partials 116 116 Continue to review full report at Codecov.
|
Deploying with Cloudflare Pages
|
@cmumatt Please add a test to the registry that includes Image shapes with |
This doesn't seem to work yet with |
Thanks! Replaced relative paths with absolute URLs in: |
This is CORS. If the web server allowed the cross-origin request or we implemented a CORS proxy, then the browser would fetch the cross-origin image successfully. I've created a separate issue (#1036) to track CORS concerns. |
Description
Fixes issue #1032
This PR provides support for absolute image URLs in Style programs within the IDE and Automator. When a URL is absolute, it is fetched directly and thus bypasses the normal example/roger/local/gist handlers.
Implementation strategy and design decisions
Detect and handle absolute image URLs. Only handle relative URLs using the existing logic in the IDE and Automator.
Checklist
diagrams/
folderOpen questions
Access-Control-Allow-Origin: *
) then the browser will not fulfill the request and the placeholder image will be displayed instead.