Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace rot90v and delete lineLength #1078

Merged
merged 1 commit into from Aug 24, 2022

Conversation

samestep
Copy link
Collaborator

Description

Similar to #1077, this PR deletes the lineLength function (unused and redundant with len), and replaces usages of rot90 and rot90v with the identical ops.rot90.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated changes to the diagrams/ folder

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #1078 (bad64b8) into main (7b9a350) will increase coverage by 0.02%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##             main    #1078      +/-   ##
==========================================
+ Coverage   64.19%   64.21%   +0.02%     
==========================================
  Files          59       59              
  Lines        7407     7400       -7     
  Branches     1674     1674              
==========================================
- Hits         4755     4752       -3     
+ Misses       2551     2547       -4     
  Partials      101      101              
Impacted Files Coverage Δ
packages/core/src/contrib/Functions.ts 29.80% <20.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bad64b8
Status: ✅  Deploy successful!
Preview URL: https://254697b8.penrose-72l.pages.dev
Branch Preview URL: https://replace-rot90v-and-linelengt.penrose-72l.pages.dev

View logs

Copy link
Contributor

@cmumatt cmumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for finding and removing these confusing redundancies!

@samestep samestep merged commit 53310b4 into main Aug 24, 2022
@samestep samestep deleted the replace-rot90v-and-linelength branch August 24, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants