fix: Reaction example Style #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1125 +/- ##
=======================================
Coverage 64.87% 64.87%
=======================================
Files 59 59
Lines 7564 7564
Branches 1703 1703
=======================================
Hits 4907 4907
Misses 2556 2556
Partials 101 101 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. Data |
Deploying with
|
| Latest commit: |
c6f9ef8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f9f5bfbc.penrose-72l.pages.dev |
| Branch Preview URL: | https://fix-reaction.penrose-72l.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@keenancrane added a Style program for reactions in #734. Because it uses
Text, we don't currently include it in the registry, so we did not catch that it broke when we merged #984. This PR fixes the issue, which was caused by reusing the variable namecin one of the Style blocks.Examples with steps to reproduce them
structural-formula/reactions/methane-combustion.substructural-formula/pseudo-3d-reaction.stystructural-formula/structural-formula.dslChecklist
diagrams/folder