-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: preset loading in synthesizer-ui
#1133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.
Data
|
Deploying with Cloudflare Pages
|
Codecov Report
@@ Coverage Diff @@
## main #1133 +/- ##
=======================================
Coverage 64.80% 64.80%
=======================================
Files 59 59
Lines 7600 7600
Branches 1697 1697
=======================================
Hits 4925 4925
Misses 2574 2574
Partials 101 101 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
remove util
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue/PR: #1119
This PR adds "presets" to
synthesizer-ui
. Allowing the user to load in pre-defined sets of Penrose trios along with synthesizer settings.Implementation strategy and design decisions
Simple
is refactored to take in an optionalstepSize
to customize the animation frame rateGridbox
now renders diagrams withanimate: true
so they don't block the UI threadexamples.ts
, which pull the trios from@penrose/examples
Examples with steps to reproduce them
Screen.Recording.2022-11-02.at.10.59.08.AM.mov
yarn turbo run start --filter-synthesizer-ui
Checklist
diagrams/
folder