-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: customizable arrowheads on both ends + new arrowhead styles #1140
Conversation
fix arrowhead offset bug
Codecov Report
@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
- Coverage 64.80% 64.56% -0.24%
==========================================
Files 59 59
Lines 7600 7629 +29
Branches 1697 1709 +12
==========================================
+ Hits 4925 4926 +1
- Misses 2574 2598 +24
- Partials 101 105 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.
Data
|
Deploying with Cloudflare Pages
|
Line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for doing this!
Description
Related issue/PR: #255, #1057
This PR introduces a few arrowhead styles inspired by quiver. The names for the arrowhead styles are still tentative. We also refactor the arrowhead properties for both
Line
andPath
:startArrowhead
andendArrowhead
fromboolean
s tostring
s and just removearrowheadStyle
arrowheadSize
and addstartArrowheadSize
andendArrowheadSize
This PR also helps with the effort on the Lean side with @Vtec234 : leanprover-community/mathlib4#363
Implementation strategy and design decisions
makeRoomForArrows
Examples with steps to reproduce them
Design file can be found in example registry
arrows-arrows
:A demo of different arrowhead settings per end:
https://arrow-styles.penrose-72l.pages.dev/try/?gist=ae798b3e7e7d14cfb09229aeedb981a9
Checklist
diagrams/
folderOpen questions
viewbox
,refX/Y
, andwidth/height
. How we can make it simpler than the current API?