Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: host tutorial in online editor #1196

Merged
merged 9 commits into from Jan 6, 2023
Merged

feat: host tutorial in online editor #1196

merged 9 commits into from Jan 6, 2023

Conversation

maxkrieger
Copy link
Member

@maxkrieger maxkrieger commented Jan 5, 2023

Description

  • Provide editor links to workspaces - no cloning needed
  • Introduce trio.json - a lightweight file format pointing to a trio in a folder, without a registry
  • In the tutorial example, add trio.json to the first three
  • Introduce ?example_trio=user/repo/triofolder query string to fetch specific trios

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

± Registry diff

📊 Performance

Key

Note that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.

     0s   1s   2s   3s   4s   5s   6s   7s   8s   9s
     |    |    |    |    |    |    |    |    |    |
name ▝▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▞▀▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▖
      compilation labelling optimization rendering

Data

                                        0s   1s   2s   3s   4s   5s   6s   7s   8s   9s
                                        |    |    |    |    |    |    |    |    |    |
3d-projection-fake-3d-linear-algebra    ▝▀▀▞▖
allShapes-allShapes                     ▝▀▀▄▚▄▄▄▄
arrowheads-arrowheads                   ▝▀▚▚
circle-example-euclidean                ▝▀▀▀▀▀▚▀▀▀▖
collinear-euclidean                     ▝▀▀▀▀▚▚
congruent-triangles-euclidean           ▝▀▀▀▀▀▀▀▀▀▀▀▞▖
continuousmap-continuousmap             ▝▀▚▚
hypergraph-hypergraph                   ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▖
incenter-triangle-euclidean             ▝▀▀▀▀▀▀▞▖
lagrange-bases-lagrange-bases           ▝▀▀▞▖
midsegment-triangles-euclidean          ▝▀▀▀▀▚▚
non-convex-non-convex                   ▝▀▀▀▀▀▚▚
one-water-molecule-atoms-and-bonds      ▝▚▚
parallel-lines-euclidean                ▝▀▀▀▀▀▚▚
persistent-homology-persistent-homology ▝▀▀▀▀▀▀▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚▖
points-around-line-shape-distance       ▝▀▀▀▀▀▚▚
points-around-polyline-shape-distance   ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▚▚
points-around-star-shape-distance       ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚▚
siggraph-teaser-euclidean-teaser        ▝▀▀▀▀▀▀▚▚
small-graph-disjoint-rect-line-horiz    ▝▀▀▀▀▀▀▀▀▀▀▀▀▞▖
small-graph-disjoint-rects              ▝▀▚▚
small-graph-disjoint-rects-large-canvas ▝▀▚▚
small-graph-disjoint-rects-small-canvas ▝▀▀▞▖
tree-tree                               ▝▀▀▄▚
tree-venn                               ▝▀▀▀▀▀▄▚
tree-venn-3d                            ▝▀▀▀▀▞▄▄
two-vectors-perp-vectors-dashed         ▝▀▚▚
vector-wedge-exterior-algebra           ▝▀▀▚▚
wet-floor-atoms-and-bonds               ▝▀▀▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚
word-cloud-example-word-cloud           ▝▀▀▀▀▀▀▚▚
wos-laplace-estimator-walk-on-spheres   ▝▀▀▀▀▀▀▀▀▚▚
wos-nested-estimator-walk-on-spheres    ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▞▀▀▀▀▀▀▀▀▖
wos-offcenter-estimator-walk-on-spheres ▝▀▀▀▀▀▀▀▀▀▀▀▞▖
wos-poisson-estimator-walk-on-spheres   ▝▀▀▀▀▀▀▀▀▀▀▀▀▚▀▀▖

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #1196 (79a6d6b) into main (2870b5f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1196   +/-   ##
=======================================
  Coverage   62.86%   62.86%           
=======================================
  Files          59       59           
  Lines        7136     7136           
  Branches     1664     1664           
=======================================
  Hits         4486     4486           
  Misses       2565     2565           
  Partials       85       85           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jan 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 79a6d6b
Status: ✅  Deploy successful!
Preview URL: https://7ecbbcb2.penrose-72l.pages.dev
Branch Preview URL: https://max-tutorial-online.penrose-72l.pages.dev

View logs

Copy link
Collaborator

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 other than some weird transparency for compile.png in dark mode.

@samestep
Copy link
Collaborator

samestep commented Jan 6, 2023

It still looks a bit weird:

Screen Shot 2023-01-06 at 9 35 43 AM

@maxkrieger
Copy link
Member Author

@samestep ok I moved it to the line beneath, see now

@samestep samestep merged commit 4f361c9 into main Jan 6, 2023
@samestep samestep deleted the max/tutorial-online branch January 6, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants