Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong flipped start arrowhead X offset #1236

Merged
merged 2 commits into from Jan 18, 2023
Merged

fix: Wrong flipped start arrowhead X offset #1236

merged 2 commits into from Jan 18, 2023

Conversation

wodeni
Copy link
Member

@wodeni wodeni commented Jan 18, 2023

Description

Fix #1220

The renderer doesn't compute the X-offset of line start with a flipped arrowhead correctly. This PR fixes this issue.

Implementation strategy and design decisions

Include a high-level summary of the implementation strategy and list important design decisions made, if any.

Examples with steps to reproduce them

https://fix-arrow-flip.penrose-72l.pages.dev/try/?gist=0d23bb22d18cfebcda7d9febd2513089

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated registry diagram changes

@wodeni wodeni self-assigned this Jan 18, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jan 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: dcd80bd
Status: ✅  Deploy successful!
Preview URL: https://840c2129.penrose-72l.pages.dev
Branch Preview URL: https://fix-arrow-flip.penrose-72l.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented Jan 18, 2023

± Registry diff

📊 Performance

Key

Note that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.

     0s   1s   2s   3s   4s   5s   6s   7s   8s   9s
     |    |    |    |    |    |    |    |    |    |
name ▝▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▞▀▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▖
      compilation labelling optimization rendering

Data

                                        0s   1s   2s   3s   4s   5s   6s   7s   8s
                                        |    |    |    |    |    |    |    |    |
3d-projection-fake-3d-linear-algebra    ▝▞▖
allShapes-allShapes                     ▝▚▚▄▖
arrowheads-arrowheads                   ▝▞▖
caffeine-structural-formula             ▝▀▀▀▚▀▖
center-shrink-circle-animation          ▝▞▖
circle-example-euclidean                ▝▀▚▀▀▀▚
collinear-euclidean                     ▝▀▞▖
congruent-triangles-euclidean           ▝▀▀▚▚
continuousmap-continuousmap             ▝▚▚
full-moon-full-moon                     ▝▀▀▀▞▀▀▖
glutamine-molecules-basic               ▝▀▚▚
half-adder-distinctive-shape            ▝▀▞▚
hypergraph-hypergraph                   ▝▀▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▖
incenter-triangle-euclidean             ▝▀▀▞▖
lagrange-bases-lagrange-bases           ▝▚▚
midsegment-triangles-euclidean          ▝▀▞▖
mobius-mobius                           ▝▞▖
non-convex-non-convex                   ▝▀▞▖
one-water-molecule-atoms-and-bonds      ▝▚▚
parallel-lines-euclidean                ▝▀▞▖
persistent-homology-persistent-homology ▝▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚▖
points-around-line-shape-distance       ▝▀▚▚
points-around-polyline-shape-distance   ▝▀▀▞▖
points-around-star-shape-distance       ▝▀▀▀▀▞▖
siggraph-teaser-euclidean-teaser        ▝▀▚▚
small-graph-disjoint-rect-line-horiz    ▝▀▀▞▖
small-graph-disjoint-rects              ▝▀▞▖
small-graph-disjoint-rects-large-canvas ▝▚▚
small-graph-disjoint-rects-small-canvas ▝▚▚
tree-tree                               ▝▀▞▖
tree-venn                               ▝▀▀▞▖
tree-venn-3d                            ▝▀▞▄▄
two-vectors-perp-vectors-dashed         ▝▚▚
vector-wedge-exterior-algebra           ▝▚▚
wet-floor-atoms-and-bonds               ▝▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▖
word-cloud-example-word-cloud           ▝▀▞▖
wos-laplace-estimator-walk-on-spheres   ▝▀▀▞▖
wos-nested-estimator-walk-on-spheres    ▝▀▀▚▀▀▀▀▀▀▀▀▀▖
wos-offcenter-estimator-walk-on-spheres ▝▀▀▞▀▀▀▚
wos-poisson-estimator-walk-on-spheres   ▝▀▚▀▚

@wodeni wodeni merged commit ce7a348 into main Jan 18, 2023
@wodeni wodeni deleted the fix-arrow-flip branch January 18, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misplaced arrows with flipped arrowheads
1 participant