Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stage reset after dragging #1237

Merged
merged 1 commit into from Jan 18, 2023
Merged

fix: Stage reset after dragging #1237

merged 1 commit into from Jan 18, 2023

Conversation

wodeni
Copy link
Member

@wodeni wodeni commented Jan 18, 2023

Description

Related issue/PR: #1199

In #1199, we changed optStages from a list to Map last minute and the type checker didn't catch the wrong usage in dragUtils.ts. This PR uses get instead of [] for stage reset.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated registry diagram changes

@wodeni wodeni self-assigned this Jan 18, 2023
@github-actions
Copy link

± Registry diff

📊 Performance

Key

Note that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.

     0s   1s   2s   3s   4s   5s   6s   7s   8s   9s
     |    |    |    |    |    |    |    |    |    |
name ▝▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▞▀▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▖
      compilation labelling optimization rendering

Data

                                        0s   1s   2s   3s   4s   5s   6s   7s
                                        |    |    |    |    |    |    |    |
3d-projection-fake-3d-linear-algebra    ▝▞▖
allShapes-allShapes                     ▝▞▄▄▖
arrowheads-arrowheads                   ▝▞▖
caffeine-structural-formula             ▝▀▀▞▚
center-shrink-circle-animation          ▝▞▖
circle-example-euclidean                ▝▀▞▀▀▚
collinear-euclidean                     ▝▚▚
congruent-triangles-euclidean           ▝▀▀▞▖
continuousmap-continuousmap             ▝▚▚
full-moon-full-moon                     ▝▀▀▞▀▀▖
glutamine-molecules-basic               ▝▀▞▖
half-adder-distinctive-shape            ▝▚▚
hypergraph-hypergraph                   ▝▀▀▚▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚
incenter-triangle-euclidean             ▝▀▞▖
lagrange-bases-lagrange-bases           ▝▚▚
midsegment-triangles-euclidean          ▝▀▞▖
mobius-mobius                           ▝▞▖
non-convex-non-convex                   ▝▚▚
one-water-molecule-atoms-and-bonds      ▝▚▚
parallel-lines-euclidean                ▝▚▚
persistent-homology-persistent-homology ▝▀▚▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚
points-around-line-shape-distance       ▝▀▞▖
points-around-polyline-shape-distance   ▝▀▚▚
points-around-star-shape-distance       ▝▀▀▚▚
siggraph-teaser-euclidean-teaser        ▝▀▞▖
small-graph-disjoint-rect-line-horiz    ▝▀▚▚
small-graph-disjoint-rects              ▝▚▚
small-graph-disjoint-rects-large-canvas ▝▞▖
small-graph-disjoint-rects-small-canvas ▝▞▖
tree-tree                               ▝▚▚
tree-venn                               ▝▀▚▚
tree-venn-3d                            ▝▚▚▖
two-vectors-perp-vectors-dashed         ▝▚▚
vector-wedge-exterior-algebra           ▝▞▖
wet-floor-atoms-and-bonds               ▝▚▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▖
word-cloud-example-word-cloud           ▝▀▞▖
wos-laplace-estimator-walk-on-spheres   ▝▀▞▖
wos-nested-estimator-walk-on-spheres    ▝▀▀▞▀▀▀▀▀▀▀▖
wos-offcenter-estimator-walk-on-spheres ▝▀▀▞▀▀▀▖
wos-poisson-estimator-walk-on-spheres   ▝▀▞▀▖

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #1237 (6fc8ad7) into main (2feae28) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1237   +/-   ##
=======================================
  Coverage   63.13%   63.13%           
=======================================
  Files          60       60           
  Lines        7061     7061           
  Branches     1646     1646           
=======================================
  Hits         4458     4458           
  Misses       2519     2519           
  Partials       84       84           
Impacted Files Coverage Δ
packages/core/src/renderer/dragUtils.ts 6.97% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6fc8ad7
Status: ✅  Deploy successful!
Preview URL: https://c6945231.penrose-72l.pages.dev
Branch Preview URL: https://fix-drag-stage.penrose-72l.pages.dev

View logs

@wodeni wodeni merged commit 9bf0a36 into main Jan 18, 2023
@wodeni wodeni deleted the fix-drag-stage branch January 18, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant