Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix import typo in components README #1253

Merged
merged 1 commit into from Jan 19, 2023
Merged

Conversation

samestep
Copy link
Collaborator

Description

The example import in the @penrose/components README is broken. This PR fixes it.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated registry diagram changes

@samestep samestep requested a review from wodeni January 19, 2023 22:09
@github-actions
Copy link

± Registry diff

📊 Performance

Key

Note that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.

     0s   1s   2s   3s   4s   5s   6s   7s   8s   9s
     |    |    |    |    |    |    |    |    |    |
name ▝▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▞▀▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▖
      compilation labelling optimization rendering

Data

                                        0s   1s   2s   3s   4s   5s   6s   7s
                                        |    |    |    |    |    |    |    |
3d-projection-fake-3d-linear-algebra    ▝▞▖
allShapes-allShapes                     ▝▚▚▄
arrowheads-arrowheads                   ▝▞▖
caffeine-structural-formula             ▝▀▀▞▚
center-shrink-circle-animation          ▝▞▖
circle-example-euclidean                ▝▀▚▀▀▚
collinear-euclidean                     ▝▀▞▖
congruent-triangles-euclidean           ▝▀▀▚▚
continuousmap-continuousmap             ▝▞▖
cubic-bezier-cubic-bezier               ▝▚▀▀▖
full-moon-full-moon                     ▝▀▀▚▀▀▚
glutamine-molecules-basic               ▝▀▞▖
half-adder-distinctive-shape            ▝▚▚
hypergraph-hypergraph                   ▝▀▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▖
incenter-triangle-euclidean             ▝▀▚▚
lagrange-bases-lagrange-bases           ▝▚▚
midsegment-triangles-euclidean          ▝▀▞▖
mobius-mobius                           ▝▞▖
non-convex-non-convex                   ▝▚▚
one-water-molecule-atoms-and-bonds      ▝▞▖
parallel-lines-euclidean                ▝▀▞▖
persistent-homology-persistent-homology ▝▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚▖
points-around-line-shape-distance       ▝▀▞▖
points-around-polyline-shape-distance   ▝▀▀▞▖
points-around-star-shape-distance       ▝▀▀▀▞▖
siggraph-teaser-euclidean-teaser        ▝▀▞▖
small-graph-disjoint-rect-line-horiz    ▝▀▚▚
small-graph-disjoint-rects              ▝▞▖
small-graph-disjoint-rects-large-canvas ▝▞▖
small-graph-disjoint-rects-small-canvas ▝▞▖
tree-tree                               ▝▀▞▖
tree-venn                               ▝▀▚▚
tree-venn-3d                            ▝▀▞▄▖
two-vectors-perp-vectors-dashed         ▝▚▚
vector-wedge-exterior-algebra           ▝▞▖
wet-floor-atoms-and-bonds               ▝▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚
word-cloud-example-word-cloud           ▝▀▞▖
wos-laplace-estimator-walk-on-spheres   ▝▀▞▖
wos-nested-estimator-walk-on-spheres    ▝▀▀▞▀▀▀▀▀▀▚
wos-offcenter-estimator-walk-on-spheres ▝▀▀▚▀▀▀▚
wos-poisson-estimator-walk-on-spheres   ▝▀▚▀▚

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1253 (0cf8bb3) into main (e1944ab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1253   +/-   ##
=======================================
  Coverage   63.44%   63.44%           
=======================================
  Files          61       61           
  Lines        7176     7176           
  Branches     1667     1667           
=======================================
  Hits         4553     4553           
  Misses       2540     2540           
  Partials       83       83           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0cf8bb3
Status: ✅  Deploy successful!
Preview URL: https://e945ebe4.penrose-72l.pages.dev
Branch Preview URL: https://components-readme-typo.penrose-72l.pages.dev

View logs

@samestep samestep changed the title fix: import typo in components README docs: fix import typo in components README Jan 19, 2023
Copy link
Member

@wodeni wodeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@samestep samestep merged commit 05b1f68 into main Jan 19, 2023
@samestep samestep deleted the components-readme-typo branch January 19, 2023 23:02
@samestep samestep mentioned this pull request Feb 2, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants