Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bring VS Code extension into this repo #1271

Merged
merged 12 commits into from Feb 2, 2023
Merged

refactor: bring VS Code extension into this repo #1271

merged 12 commits into from Feb 2, 2023

Conversation

samestep
Copy link
Collaborator

@samestep samestep commented Jan 26, 2023

Description

Resolves #1270. Depends on #1280.

Implementation strategy and design decisions

The first commit 284003c in this PR simply copies all the files from https://github.com/penrose/penrose-vscode/tree/aa02100b83339cc61a07a840737272033ec6fe71 directly into a new packages/vscode/ folder here. Then, after doing that, I did some cleanup.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated registry diagram changes

@github-actions
Copy link

github-actions bot commented Jan 26, 2023

± Registry diff

📊 Performance

Key

Note that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.

     0s   1s   2s   3s   4s   5s   6s   7s   8s   9s
     |    |    |    |    |    |    |    |    |    |
name ▝▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▞▀▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▖
      compilation labelling optimization rendering

Data

                                        0s   1s   2s   3s   4s   5s   6s   7s
                                        |    |    |    |    |    |    |    |
3d-projection-fake-3d-linear-algebra    ▝▞▖
allShapes-allShapes                     ▝▞▄▄▄▄▄
arrowheads-arrowheads                   ▝▞▖
caffeine-structural-formula             ▝▀▀▞▀▖
center-shrink-circle-animation          ▝▞▖
circle-example-euclidean                ▝▀▞▀▀▚
collinear-euclidean                     ▝▚▚
congruent-triangles-euclidean           ▝▀▀▞▖
continuousmap-continuousmap             ▝▚▚
cubic-bezier-cubic-bezier               ▝▚▀▀▚
glutamine-molecules-basic               ▝▀▞▖
half-adder-distinctive-shape            ▝▚▚
hypergraph-hypergraph                   ▝▀▀▚▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚
incenter-triangle-euclidean             ▝▀▞▖
lagrange-bases-lagrange-bases           ▝▚▚
midsegment-triangles-euclidean          ▝▀▞▖
mobius-mobius                           ▝▞▖
non-convex-non-convex                   ▝▚▚
one-water-molecule-atoms-and-bonds      ▝▞▖
parallel-lines-euclidean                ▝▚▚
persistent-homology-persistent-homology ▝▀▚▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚
points-around-line-shape-distance       ▝▀▞▖
points-around-polyline-shape-distance   ▝▀▚▚
points-around-star-shape-distance       ▝▀▀▚▚
siggraph-teaser-euclidean-teaser        ▝▀▞▖
small-graph-disjoint-rect-line-horiz    ▝▀▀▞▖
small-graph-disjoint-rects              ▝▞▖
small-graph-disjoint-rects-large-canvas ▝▞▖
small-graph-disjoint-rects-small-canvas ▝▞▖
tree-tree                               ▝▀▞▖
tree-venn                               ▝▀▚▚
tree-venn-3d                            ▝▚▚▄▄
two-vectors-perp-vectors-dashed         ▝▚▚
vector-wedge-exterior-algebra           ▝▞▖
wet-floor-atoms-and-bonds               ▝▚▀▀▖
word-cloud-example-word-cloud           ▝▀▞▖
wos-laplace-estimator-walk-on-spheres   ▝▀▞▖
wos-nested-estimator-walk-on-spheres    ▝▀▀▞▀▀▀▀▀▀▀▖
wos-offcenter-estimator-walk-on-spheres ▝▀▞▀▀▀▖
wos-poisson-estimator-walk-on-spheres   ▝▀▞▀▖

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #1271 (bd05d6d) into main (6e83596) will not change coverage.
The diff coverage is n/a.

❗ Current head bd05d6d differs from pull request most recent head f77f224. Consider uploading reports for the commit f77f224 to get more accurate results

@@           Coverage Diff           @@
##             main    #1271   +/-   ##
=======================================
  Coverage   63.43%   63.43%           
=======================================
  Files          61       61           
  Lines        7212     7212           
  Branches     1680     1680           
=======================================
  Hits         4575     4575           
  Misses       2553     2553           
  Partials       84       84           
Impacted Files Coverage Δ
packages/core/src/utils/Graph.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jan 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f77f224
Status: ✅  Deploy successful!
Preview URL: https://7e0c2b77.penrose-72l.pages.dev
Branch Preview URL: https://vscode.penrose-72l.pages.dev

View logs

@samestep samestep marked this pull request as ready for review February 2, 2023 01:57
@samestep samestep requested a review from wodeni February 2, 2023 01:57
@samestep samestep merged commit a74a7e2 into main Feb 2, 2023
@samestep samestep deleted the vscode branch February 2, 2023 15:11
@samestep samestep mentioned this pull request Feb 2, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move VS Code extension into this monorepo
1 participant