build: monorepo-aware reloading in editor
#1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
± Registry diff📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms. Data |
Codecov Report
@@ Coverage Diff @@
## main #1286 +/- ##
=======================================
Coverage 63.43% 63.43%
=======================================
Files 61 61
Lines 7212 7212
Branches 1680 1680
=======================================
Hits 4575 4575
Misses 2553 2553
Partials 84 84
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Deploying with
|
| Latest commit: |
c93e960
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2573faa3.penrose-72l.pages.dev |
| Branch Preview URL: | https://vite-link.penrose-72l.pages.dev |
Related: #1189 |
samestep
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Amazing, thanks for doing this Nimo! One thing to think about: now the only source package this doesn't work for is @penrose/optimizer which has a more complicated build process that Vite doesn't understand, which is why we still need "dependsOn": ["^build"] for the three dev tasks packages/editor/package.json. But those tasks don't actually depend on core:build or components:build, just optimizer:build. Doesn't really matter though :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we had trouble watching changes from packages in our monorepo. For instance, a change in
@penrose/corewill not trigger a reload when runningyarn startbecause it only watches source file changes within@penrose/editor.After #1160, all of our packages are ES modules and vite is capable of treating ESM dependencies as source. This PR configures
@penrose/editorsuch that it watches changes from bothcoreandcomponents.Implementation strategy and design decisions
coreas source,editor's vite config also needs to know about how to deal with top level await. Added the suggested plugin.ttscincore. Therefore, we need to make surecorehas minimal configuration. This PR removesttscfromcoreand changed all absolute path imports to relative.../<module>/file, which is pretty logical.Examples with steps to reproduce them
Run
yarn start. Touch any files incoreorcomponentsto trigger HMR in vite.Checklist
Open questions
This issue was very helpful for this PR, but I couldn't reproduce the regex-based approach because
examplesandoptimizerhave different folder structures. I'm inclined to keep the aliases explicit because it's much more transparent.