Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added "ctrl+enter" binding for recompiling #1306

Merged
merged 3 commits into from Feb 15, 2023
Merged

Conversation

Dsm0
Copy link
Contributor

@Dsm0 Dsm0 commented Feb 8, 2023

Description

Resolves #1272

"ctrl+enter" now functions identically to :w in VimMode.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new ESLint warnings
  • I have reviewed any generated registry diagram changes

@cloudflare-pages
Copy link

cloudflare-pages bot commented Feb 8, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5765446
Status: ✅  Deploy successful!
Preview URL: https://b3a9d586.penrose-72l.pages.dev
Branch Preview URL: https://recompile-shortcut.penrose-72l.pages.dev

View logs

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #1306 (5765446) into main (f692a44) will decrease coverage by 2.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
- Coverage   63.43%   61.30%   -2.13%     
==========================================
  Files          61       63       +2     
  Lines        7212     7826     +614     
  Branches     1680     1842     +162     
==========================================
+ Hits         4575     4798     +223     
- Misses       2553     2922     +369     
- Partials       84      106      +22     
Impacted Files Coverage Δ
packages/core/src/engine/Autodiff.ts 79.38% <0.00%> (-11.67%) ⬇️
packages/core/src/analysis/SubstanceAnalysis.ts 66.06% <0.00%> (-8.80%) ⬇️
packages/core/src/compiler/Style.ts 63.65% <0.00%> (-4.86%) ⬇️
packages/core/src/synthesis/Synthesizer.ts 26.05% <0.00%> (-0.70%) ⬇️
packages/core/src/renderer/Line.ts 2.83% <0.00%> (-0.03%) ⬇️
packages/core/src/parser/ParserUtil.ts 98.78% <0.00%> (ø)
packages/core/src/renderer/Renderer.ts 25.92% <0.00%> (ø)
packages/core/src/renderer/util.ts 3.17% <0.00%> (ø)
packages/core/src/utils/Heap.ts 56.71% <0.00%> (ø)
packages/core/src/synthesis/Mutation.ts 48.28% <0.00%> (+0.40%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

± Registry diff

M	3d-projection-fake-3d-linear-algebra.svg
M	arrowheads-arrowheads.svg
M	collinear-euclidean.svg
M	continuousmap-continuousmap.svg
M	matrix-matrix-addition-matrix-ops.svg
M	matrix-matrix-division-elementwise-matrix-ops.svg
M	matrix-matrix-multiplication-elementwise-matrix-ops.svg
M	matrix-matrix-multiplication-matrix-ops.svg
M	matrix-matrix-subtraction-matrix-ops.svg
M	matrix-transpose-matrix-ops.svg
M	matrix-vector-left-multiplication-matrix-ops.svg
M	matrix-vector-right-multiplication-matrix-ops.svg
M	parallel-lines-euclidean.svg
M	persistent-homology-persistent-homology.svg
M	scalar-vector-division-matrix-ops.svg
M	scalar-vector-left-multiplication-matrix-ops.svg
M	scalar-vector-right-multiplication-matrix-ops.svg
M	siggraph-teaser-euclidean-teaser.svg
M	tree-tree.svg
M	tree-venn-3d.svg
M	two-vectors-perp-vectors-dashed.svg
M	vector-vector-addition-matrix-ops.svg
M	vector-vector-division-elementwise-matrix-ops.svg
M	vector-vector-multiplication-elementwise-matrix-ops.svg
M	vector-vector-outerproduct-matrix-ops.svg
M	vector-vector-subtraction-matrix-ops.svg
M	vector-wedge-exterior-algebra.svg

📊 Performance

Key

Note that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.

     0s   1s   2s   3s   4s   5s   6s   7s   8s   9s
     |    |    |    |    |    |    |    |    |    |
name ▝▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▞▀▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▖
      compilation labelling optimization rendering

Data

                                                    0s   1s   2s   3s   4s   5s   6s   7s
                                                    |    |    |    |    |    |    |    |
3d-projection-fake-3d-linear-algebra                ▝▞▖
allShapes-allShapes                                 ▝▞▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
arrowheads-arrowheads                               ▝▞▖
caffeine-structural-formula                         ▝▀▀▞▚
center-shrink-circle-animation                      ▝▞▖
circle-example-euclidean                            ▝▀▞▀▀▖
closest-point-test-closest-point                    ▝▀▀▀▀▚▚
collinear-euclidean                                 ▝▚▚
congruent-triangles-euclidean                       ▝▀▚▚
continuousmap-continuousmap                         ▝▞▖
cubic-bezier-cubic-bezier                           ▝▚▀▀▖
glutamine-molecules-basic                           ▝▀▞▖
half-adder-distinctive-shape                        ▝▚▚
hypergraph-hypergraph                               ▝▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▖
incenter-triangle-euclidean                         ▝▀▞▖
lagrange-bases-lagrange-bases                       ▝▚▚
matrix-matrix-addition-matrix-ops                   ▝▚▚
matrix-matrix-division-elementwise-matrix-ops       ▝▚▚
matrix-matrix-multiplication-elementwise-matrix-ops ▝▚▚
matrix-matrix-multiplication-matrix-ops             ▝▚▚
matrix-matrix-subtraction-matrix-ops                ▝▚▚
matrix-transpose-matrix-ops                         ▝▞▖
matrix-vector-left-multiplication-matrix-ops        ▝▚▚
matrix-vector-right-multiplication-matrix-ops       ▝▞▖
midsegment-triangles-euclidean                      ▝▚▚
mobius-mobius                                       ▝▞▖
non-convex-non-convex                               ▝▀▞▖
one-water-molecule-atoms-and-bonds                  ▝▞▖
parallel-lines-euclidean                            ▝▚▀▖
persistent-homology-persistent-homology             ▝▀▚▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▖
points-around-line-shape-distance                   ▝▀▞▖
points-around-polyline-shape-distance               ▝▀▚▚
points-around-star-shape-distance                   ▝▀▀▚▚
quaternion-group-group-theory-cayley-graph          ▝▀▞▖
quaternion-group-group-theory-multiplication-table  ▝▀▀▚▞▖
scalar-vector-division-matrix-ops                   ▝▚▚
scalar-vector-left-multiplication-matrix-ops        ▝▞▖
scalar-vector-right-multiplication-matrix-ops       ▝▞▖
siggraph-teaser-euclidean-teaser                    ▝▀▞▖
small-graph-disjoint-rect-line-horiz                ▝▀▞▖
small-graph-disjoint-rects                          ▝▞▖
small-graph-disjoint-rects-large-canvas             ▝▞▖
small-graph-disjoint-rects-small-canvas             ▝▞▖
tree-tree                                           ▝▀▞▖
tree-venn                                           ▝▀▚▚
tree-venn-3d                                        ▝▚▚▄
two-triangles-triangle-mesh-3d                      ▝▚▚
two-vectors-perp-vectors-dashed                     ▝▞▖
vector-vector-addition-matrix-ops                   ▝▚▚
vector-vector-division-elementwise-matrix-ops       ▝▞▖
vector-vector-multiplication-elementwise-matrix-ops ▝▞▖
vector-vector-outerproduct-matrix-ops               ▝▞▖
vector-vector-subtraction-matrix-ops                ▝▞▖
vector-wedge-exterior-algebra                       ▝▞▖
wet-floor-atoms-and-bonds                           ▝▚▀▀▖
word-cloud-example-word-cloud                       ▝▚▚
wos-laplace-estimator-walk-on-spheres               ▝▀▚▚
wos-nested-estimator-walk-on-spheres                ▝▀▀▞▀▀▖
wos-offcenter-estimator-walk-on-spheres             ▝▀▞▀▀▀▖
wos-poisson-estimator-walk-on-spheres               ▝▀▞▀▖

Copy link
Member

@wodeni wodeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small comment below.

packages/components/src/editing/EditorPane.tsx Outdated Show resolved Hide resolved
@Dsm0 Dsm0 requested review from wodeni February 15, 2023 20:31
@samestep samestep merged commit d0472d1 into main Feb 15, 2023
@samestep samestep deleted the recompile-shortcut branch February 15, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide non-Vim keyboard shortcut to recompile
3 participants