Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: github action node version #1318

Merged
merged 2 commits into from Feb 21, 2023
Merged

fix: github action node version #1318

merged 2 commits into from Feb 21, 2023

Conversation

liangyiliang
Copy link
Contributor

@liangyiliang liangyiliang commented Feb 21, 2023

GitHub action updated to, by default, use Node 18, which breaks some dependencies. See here.

For now, we are forcing GitHub action to use Node 16.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Feb 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e6ca3ba
Status: ✅  Deploy successful!
Preview URL: https://9536e084.penrose-72l.pages.dev
Branch Preview URL: https://fix-node.penrose-72l.pages.dev

View logs

@github-actions
Copy link

± Registry diff

M	3d-projection-fake-3d-linear-algebra.svg
M	arrowheads-arrowheads.svg
M	collinear-euclidean.svg
M	continuousmap-continuousmap.svg
M	matrix-matrix-addition-matrix-ops.svg
M	matrix-matrix-division-elementwise-matrix-ops.svg
M	matrix-matrix-multiplication-elementwise-matrix-ops.svg
M	matrix-matrix-multiplication-matrix-ops.svg
M	matrix-matrix-subtraction-matrix-ops.svg
M	matrix-transpose-matrix-ops.svg
M	matrix-vector-left-multiplication-matrix-ops.svg
M	matrix-vector-right-multiplication-matrix-ops.svg
M	parallel-lines-euclidean.svg
M	persistent-homology-persistent-homology.svg
M	scalar-vector-division-matrix-ops.svg
M	scalar-vector-left-multiplication-matrix-ops.svg
M	scalar-vector-right-multiplication-matrix-ops.svg
M	siggraph-teaser-euclidean-teaser.svg
M	tree-tree.svg
M	tree-venn-3d.svg
M	two-vectors-perp-vectors-dashed.svg
M	vector-vector-addition-matrix-ops.svg
M	vector-vector-division-elementwise-matrix-ops.svg
M	vector-vector-multiplication-elementwise-matrix-ops.svg
M	vector-vector-outerproduct-matrix-ops.svg
M	vector-vector-subtraction-matrix-ops.svg
M	vector-wedge-exterior-algebra.svg

📊 Performance

Key

Note that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.

     0s   1s   2s   3s   4s   5s   6s   7s   8s   9s
     |    |    |    |    |    |    |    |    |    |
name ▝▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▞▀▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▖
      compilation labelling optimization rendering

Data

                                                    0s   1s   2s   3s   4s   5s   6s   7s
                                                    |    |    |    |    |    |    |    |
3d-projection-fake-3d-linear-algebra                ▝▞▖
allShapes-allShapes                                 ▝▞▄▄▄
arrowheads-arrowheads                               ▝▞▖
caffeine-structural-formula                         ▝▀▀▞▚
center-shrink-circle-animation                      ▝▞▖
circle-example-euclidean                            ▝▀▞▀▀▖
closest-point-test-closest-point                    ▝▀▀▀▀▀▞▖
collinear-euclidean                                 ▝▚▚
congruent-triangles-euclidean                       ▝▀▚▚
continuousmap-continuousmap                         ▝▞▖
cubic-bezier-cubic-bezier                           ▝▚▀▀▖
glutamine-molecules-basic                           ▝▀▞▖
half-adder-distinctive-shape                        ▝▚▚
hypergraph-hypergraph                               ▝▀▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▖
incenter-triangle-euclidean                         ▝▀▞▖
lagrange-bases-lagrange-bases                       ▝▞▖
matrix-matrix-addition-matrix-ops                   ▝▚▚
matrix-matrix-division-elementwise-matrix-ops       ▝▚▚
matrix-matrix-multiplication-elementwise-matrix-ops ▝▚▚
matrix-matrix-multiplication-matrix-ops             ▝▚▚
matrix-matrix-subtraction-matrix-ops                ▝▚▚
matrix-transpose-matrix-ops                         ▝▞▖
matrix-vector-left-multiplication-matrix-ops        ▝▞▖
matrix-vector-right-multiplication-matrix-ops       ▝▞▖
midsegment-triangles-euclidean                      ▝▚▚
mobius-mobius                                       ▝▞▖
non-convex-non-convex                               ▝▚▚
one-water-molecule-atoms-and-bonds                  ▝▞▖
parallel-lines-euclidean                            ▝▚▀▖
persistent-homology-persistent-homology             ▝▀▚▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▖
points-around-line-shape-distance                   ▝▀▞▖
points-around-polyline-shape-distance               ▝▀▚▚
points-around-star-shape-distance                   ▝▀▀▚▚
quaternion-group-group-theory-cayley-graph          ▝▀▚▚
quaternion-group-group-theory-multiplication-table  ▝▀▀▄▚
scalar-vector-division-matrix-ops                   ▝▞▖
scalar-vector-left-multiplication-matrix-ops        ▝▞▖
scalar-vector-right-multiplication-matrix-ops       ▝▚▚
siggraph-teaser-euclidean-teaser                    ▝▀▞▖
small-graph-disjoint-rect-line-horiz                ▝▀▞▖
small-graph-disjoint-rects                          ▝▞▖
small-graph-disjoint-rects-large-canvas             ▝▞▖
small-graph-disjoint-rects-small-canvas             ▝▞▖
tree-tree                                           ▝▚▚
tree-venn                                           ▝▀▚▚
tree-venn-3d                                        ▝▀▞▄▖
two-triangles-triangle-mesh-3d                      ▝▚▚
two-vectors-perp-vectors-dashed                     ▝▞▖
vector-vector-addition-matrix-ops                   ▝▞▖
vector-vector-division-elementwise-matrix-ops       ▝▞▖
vector-vector-multiplication-elementwise-matrix-ops ▝▞▖
vector-vector-outerproduct-matrix-ops               ▝▞▖
vector-vector-subtraction-matrix-ops                ▝▞▖
vector-wedge-exterior-algebra                       ▝▞▖
wet-floor-atoms-and-bonds                           ▝▚▀▀▖
word-cloud-example-word-cloud                       ▝▚▚
wos-laplace-estimator-walk-on-spheres               ▝▀▞▖
wos-nested-estimator-walk-on-spheres                ▝▀▀▞▀▀▖
wos-offcenter-estimator-walk-on-spheres             ▝▀▞▀▀▀▖
wos-poisson-estimator-walk-on-spheres               ▝▀▞▀▖

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #1318 (e6ca3ba) into main (5ec39dd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1318   +/-   ##
=======================================
  Coverage   61.30%   61.30%           
=======================================
  Files          63       63           
  Lines        7826     7826           
  Branches     1842     1842           
=======================================
  Hits         4798     4798           
  Misses       2922     2922           
  Partials      106      106           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@liangyiliang liangyiliang marked this pull request as ready for review February 21, 2023 21:56
@liangyiliang liangyiliang merged commit 0d52677 into main Feb 21, 2023
@samestep samestep mentioned this pull request Feb 22, 2023
3 tasks
@liangyiliang liangyiliang deleted the fix-node branch February 24, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants