Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Lewis structures examples to synthesizer-ui #1334

Merged
merged 31 commits into from Mar 10, 2023
Merged

Conversation

wodeni
Copy link
Member

@wodeni wodeni commented Mar 7, 2023

Description

This PR adds 6 problems about Lewis structures from the Open Learning Initiative General Chemistry I course to synthesizer-ui.

Implementation strategy and design decisions

  • Add some lewis structure problems with a single shared configuration. Note that this config is distinct from the geometry configuration. In other words, the config is domain-specific.
  • Add support for TeX expressions in problem prompt.

Examples with steps to reproduce them

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have reviewed any generated registry diagram changes

@wodeni wodeni marked this pull request as draft March 7, 2023 20:56
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

± Registry diff

M	nitricacid-lewis.svg

📊 Performance

Key

Note that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.

     0s   1s   2s   3s   4s   5s   6s   7s   8s   9s
     |    |    |    |    |    |    |    |    |    |
name ▝▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▞▀▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▖
      compilation labelling optimization rendering

Data

                                                    0s   1s   2s   3s   4s   5s   6s   7s
                                                    |    |    |    |    |    |    |    |
3d-projection-fake-3d-linear-algebra                ▝▞▖
allShapes-allShapes                                 ▝▚▚▄▄
arrowheads-arrowheads                               ▝▞▖
caffeine-structural-formula                         ▝▀▀▞▚
center-shrink-circle-animation                      ▝▞▖
circle-example-euclidean                            ▝▀▞▖
closest-point-test-closest-point                    ▝▀▀▀▀▀▀▞▖
collinear-euclidean                                 ▝▀▞▖
congruent-triangles-euclidean                       ▝▀▀▞▖
continuousmap-continuousmap                         ▝▞▖
cubic-bezier-cubic-bezier                           ▝▚▀▚
glutamine-molecules-basic                           ▝▀▞▖
half-adder-distinctive-shape                        ▝▚▀▖
hypergraph-hypergraph                               ▝▀▀▚▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▖
incenter-triangle-euclidean                         ▝▀▞▖
lagrange-bases-lagrange-bases                       ▝▞▖
lines-around-rect-rect-line-dist                    ▝▚▚
matrix-matrix-addition-matrix-ops                   ▝▚▚
matrix-matrix-division-elementwise-matrix-ops       ▝▚▚
matrix-matrix-multiplication-elementwise-matrix-ops ▝▚▚
matrix-matrix-multiplication-matrix-ops             ▝▚▚
matrix-matrix-subtraction-matrix-ops                ▝▚▚
matrix-transpose-matrix-ops                         ▝▚▚
matrix-vector-left-multiplication-matrix-ops        ▝▚▚
matrix-vector-right-multiplication-matrix-ops       ▝▚▚
midsegment-triangles-euclidean                      ▝▀▞▖
mobius-mobius                                       ▝▞▖
nitricacid-lewis                                    ▝▀▚▀▀▖
non-convex-non-convex                               ▝▚▚
one-water-molecule-atoms-and-bonds                  ▝▚▚
parallel-lines-euclidean                            ▝▀▞▖
persistent-homology-persistent-homology             ▝▀▚▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚▖
points-around-line-shape-distance                   ▝▀▞▖
points-around-polyline-shape-distance               ▝▀▚▚
points-around-star-shape-distance                   ▝▀▀▀▞▖
quaternion-group-group-theory-cayley-graph          ▝▀▚▚
quaternion-group-group-theory-multiplication-table  ▝▀▀▀▄▞▖
scalar-vector-division-matrix-ops                   ▝▚▚
scalar-vector-left-multiplication-matrix-ops        ▝▚▚
scalar-vector-right-multiplication-matrix-ops       ▝▞▖
siggraph-teaser-euclidean-teaser                    ▝▀▞▖
small-graph-disjoint-rect-line-horiz                ▝▀▚▚
small-graph-disjoint-rects                          ▝▞▖
small-graph-disjoint-rects-large-canvas             ▝▞▖
small-graph-disjoint-rects-small-canvas             ▝▞▖
tree-tree                                           ▝▀▞▖
tree-venn                                           ▝▀▞▖
tree-venn-3d                                        ▝▚▚▄▄▖
two-triangles-triangle-mesh-3d                      ▝▚▚
two-vectors-perp-vectors-dashed                     ▝▚▚
vector-vector-addition-matrix-ops                   ▝▚▚
vector-vector-division-elementwise-matrix-ops       ▝▚▚
vector-vector-multiplication-elementwise-matrix-ops ▝▚▚
vector-vector-outerproduct-matrix-ops               ▝▚▚
vector-vector-subtraction-matrix-ops                ▝▚▚
vector-wedge-exterior-algebra                       ▝▚▚
wet-floor-atoms-and-bonds                           ▝▀▞▀▖
word-cloud-example-word-cloud                       ▝▀▞▖
wos-laplace-estimator-walk-on-spheres               ▝▀▞▖
wos-nested-estimator-walk-on-spheres                ▝▀▀▞▀▚
wos-offcenter-estimator-walk-on-spheres             ▝▀▞▀▖
wos-poisson-estimator-walk-on-spheres               ▝▀▚▀▚

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #1334 (0a97229) into main (5411f35) will increase coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 0a97229 differs from pull request most recent head d5cab86. Consider uploading reports for the commit d5cab86 to get more accurate results

@@            Coverage Diff             @@
##             main    #1334      +/-   ##
==========================================
+ Coverage   61.89%   61.92%   +0.03%     
==========================================
  Files          65       65              
  Lines        8103     8098       -5     
  Branches     1887     1886       -1     
==========================================
  Hits         5015     5015              
+ Misses       2980     2975       -5     
  Partials      108      108              
Impacted Files Coverage Δ
packages/core/src/synthesis/Synthesizer.ts 26.36% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Mar 7, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d5cab86
Status: ✅  Deploy successful!
Preview URL: https://1d3560ec.penrose-72l.pages.dev
Branch Preview URL: https://edgeworth-lewis.penrose-72l.pages.dev

View logs

@wodeni wodeni marked this pull request as ready for review March 10, 2023 19:15
@wodeni wodeni merged commit 2f1f624 into main Mar 10, 2023
@wodeni wodeni deleted the edgeworth/lewis branch March 10, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant