-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: split valence electrons into predicates #1347
Conversation
Deploying with Cloudflare Pages
|
± Registry diff
📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.
Data
|
Codecov Report
@@ Coverage Diff @@
## main #1347 +/- ##
=======================================
Coverage 62.11% 62.11%
=======================================
Files 67 67
Lines 8561 8561
Branches 2052 2052
=======================================
Hits 5318 5318
Misses 3105 3105
Partials 138 138 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Description
Following up on #1345, this PR modifies our
molecules.domain
andlewis.style
to use onlypredicate
s for valence electrons, instead of aconstructor
. This allows us to add or remove valence electron pairs on atoms via only edit-type mutations, instead of add- or remove-type mutations.Implementation strategy and design decisions
This change involved a quadratic amount of code duplication in the Style program.
Checklist