Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: line wrap in error pane #1357

Merged
merged 1 commit into from May 4, 2023
Merged

feat: line wrap in error pane #1357

merged 1 commit into from May 4, 2023

Conversation

liangyiliang
Copy link
Contributor

@liangyiliang liangyiliang commented May 4, 2023 •
edited by samestep

Description

Resolves #1356.

Now the error pane looks like this:
image

@liangyiliang liangyiliang marked this pull request as ready for review May 4, 2023 17:48
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a64a76f
Status: ✅  Deploy successful!
Preview URL: https://acbfda24.penrose-72l.pages.dev
Branch Preview URL: https://error-wrap.penrose-72l.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented May 4, 2023

± Registry diff

📊 Performance

Key

Note that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.

     0s   1s   2s   3s   4s   5s   6s   7s   8s   9s
     |    |    |    |    |    |    |    |    |    |
name ▝▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▞▀▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▖
      compilation labelling optimization rendering

Data

                                                                  0s   1s   2s   3s   4s   5s
                                                                  |    |    |    |    |    |
3d-projection-fake-3d-linear-algebra                              ▝▞▖
acquaintanceship-graph-simple-graph                               ▝▀▀▀▀▀▀▀▀▀▀▀▀▚▀▀▀▀▀▀▖
allShapes-allShapes                                               ▝▞▄▖
angle-equivalence-triangle-mesh-2d                                ▝▀▚▀▚
arrowheads-arrowheads                                             ▝▞▖
caffeine-structural-formula                                       ▝▀▀▞▖
call-directed-graph-directed-multigraph                           ▝▀▀▀▀▀▚▀▀▖
call-undirected-graph-pseudograph                                 ▝▀▀▀▚▚
center-shrink-circle-animation                                    ▝▞▖
circle-example-euclidean                                          ▝▀▞▖
closest-point-test-closest-point                                  ▝▀▀▀▀▚▚
collinear-euclidean                                               ▝▚▚
communications-network-one-way-links-graph-simple-directed-graph  ▝▀▀▀▚▀▖
complete-bipartite-graphs-simple-graph                            ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▞▀▀▖
complete-graphs-simple-graph                                      ▝▀▀▀▀▀▀▚▀▚
computer-network-diagnostic-links-graph-pseudograph               ▝▀▀▀▚▚
computer-network-graph-simple-graph                               ▝▀▀▚▚
computer-network-multiple-links-graph-pseudograph                 ▝▀▀▀▚▀▚
computer-network-multiple-one-way-links-graph-directed-multigraph ▝▀▀▀▀▀▀▞▚
concyclic-pair-triangle-mesh-2d                                   ▝▚▚
congruent-triangles-euclidean                                     ▝▀▀▞▖
continuousmap-continuousmap                                       ▝▞▖
cotan-formula-triangle-mesh-2d                                    ▝▀▞▖
cube-graphs-simple-graph                                          ▝▀▀▀▀▀▀▀▀▚▀▖
cubic-bezier-cubic-bezier                                         ▝▚▀▖
cycle-graphs-simple-graph                                         ▝▀▀▀▀▀▞▀▖
glutamine-molecules-basic                                         ▝▀▞▖
half-adder-distinctive-shape                                      ▝▚▚
halfedge-mesh-triangle-mesh-2d                                    ▝▚▚
hybrid-topology-graph-simple-graph                                ▝▀▚▚
hypercube-network-graph-simple-graph                              ▝▀▀▀▞▖
hypergraph-hypergraph                                             ▝▀▀▚▀▀▀▀▀▀▀▖
incenter-triangle-euclidean                                       ▝▀▞▖
influence-graph-simple-directed-graph                             ▝▀▚▚
jobs-trained-matching-graph-simple-graph                          ▝▀▀▀▞▚
jobs-trained-no-matching-graph-simple-graph                       ▝▀▀▚▚
lagrange-bases-lagrange-bases                                     ▝▞▖
linear-array-graph-simple-graph                                   ▝▀▞▖
lines-around-rect-rect-line-dist                                  ▝▀▚▚
matrix-matrix-addition-matrix-ops                                 ▝▚▚
matrix-matrix-division-elementwise-matrix-ops                     ▝▚▚
matrix-matrix-multiplication-elementwise-matrix-ops               ▝▚▚
matrix-matrix-multiplication-matrix-ops                           ▝▚▚
matrix-matrix-subtraction-matrix-ops                              ▝▚▚
matrix-transpose-matrix-ops                                       ▝▚▚
matrix-vector-left-multiplication-matrix-ops                      ▝▚▚
matrix-vector-right-multiplication-matrix-ops                     ▝▚▚
mesh-network-graph-simple-graph                                   ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▞▀▀▀▀▀▀▀▀▀▖
midsegment-triangles-euclidean                                    ▝▀▞▖
mobius-mobius                                                     ▝▞▖
module-dependency-graph-simple-directed-graph                     ▝▀▀▚▀▖
niche-overlap-graph-simple-graph                                  ▝▀▀▀▀▞▖
nitricacid-lewis                                                  ▝▀▀▞▀▖
non-convex-non-convex                                             ▝▚▚
one-water-molecule-atoms-and-bonds                                ▝▞▖
parallel-lines-euclidean                                          ▝▚▚
persistent-homology-persistent-homology                           ▝▀▚▀▀▀▀▀▀▖
points-around-line-shape-distance                                 ▝▀▞▖
points-around-polyline-shape-distance                             ▝▀▚▚
points-around-star-shape-distance                                 ▝▀▀▚▚
precedence-graph-simple-directed-graph                            ▝▀▀▞▖
protein-interaction-graph-simple-graph                            ▝▀▀▀▀▀▞▀▚
quaternion-group-group-theory-cayley-graph                        ▝▀▞▖
quaternion-group-group-theory-multiplication-table                ▝▀▀▄▚
relative-orientation-triangle-mesh-2d                             ▝▚▚
ring-topology-graph-simple-graph                                  ▝▀▞▖
round-robin-graph-simple-directed-graph                           ▝▀▀▀▀▞▖
scalar-vector-division-matrix-ops                                 ▝▞▖
scalar-vector-left-multiplication-matrix-ops                      ▝▚▚
scalar-vector-right-multiplication-matrix-ops                     ▝▞▖
siggraph-teaser-euclidean-teaser                                  ▝▀▞▖
star-topology-graph-simple-graph                                  ▝▀▞▖
tree-tree                                                         ▝▀▞▖
tree-venn                                                         ▝▀▞▖
tree-venn-3d                                                      ▝▚▚▄▖
triangle-centers-triangle-mesh-2d                                 ▝▚▚
two-triangles-triangle-mesh-3d                                    ▝▚▚
two-vectors-perp-vectors-dashed                                   ▝▞▖
union-graph-simple-graph                                          ▝▀▀▞▖
vector-vector-addition-matrix-ops                                 ▝▞▖
vector-vector-division-elementwise-matrix-ops                     ▝▚▚
vector-vector-multiplication-elementwise-matrix-ops               ▝▞▖
vector-vector-outerproduct-matrix-ops                             ▝▚▚
vector-vector-subtraction-matrix-ops                              ▝▞▖
vector-wedge-exterior-algebra                                     ▝▞▖
wet-floor-atoms-and-bonds                                         ▝▚▀▖
wheel-graphs-simple-graph                                         ▝▀▀▀▀▀▀▀▀▞▀▖
word-cloud-example-word-cloud                                     ▝▀▞▖
wos-laplace-estimator-walk-on-spheres                             ▝▀▞▖
wos-nested-estimator-walk-on-spheres                              ▝▀▚▀▖
wos-offcenter-estimator-walk-on-spheres                           ▝▀▞▚
wos-poisson-estimator-walk-on-spheres                             ▝▀▞▚

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #1357 (a64a76f) into main (8df3229) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1357   +/-   ##
=======================================
  Coverage   62.70%   62.70%           
=======================================
  Files          70       70           
  Lines        8738     8738           
  Branches     2110     2110           
=======================================
  Hits         5479     5479           
  Misses       3116     3116           
  Partials      143      143

@samestep samestep mentioned this pull request May 4, 2023
Closed
samestep
samestep approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 @wodeni?

wodeni
wodeni approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@wodeni wodeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liangyiliang liangyiliang merged commit 58bd78b into main May 4, 2023
12 checks passed
@liangyiliang liangyiliang deleted the error-wrap branch May 4, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samestep samestep samestep approved these changes

@wodeni wodeni wodeni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Line-wrapping in error panes
3 participants
@liangyiliang @samestep @wodeni