Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show warnings in editor #1381

Merged
merged 3 commits into from May 11, 2023
Merged

feat: show warnings in editor #1381

merged 3 commits into from May 11, 2023

Conversation

wodeni
Copy link
Member

@wodeni wodeni commented May 11, 2023

Description

Resolves #1305.

This PR displays warnings in editor. The current implementation simply shows them in the diagram panel, just like errors but in a different color:

image

Like shown in the screenshot, some of our gallery diagrams contain warnings (mostly ImplicitOverrideWarning).

Implementation strategy and design decisions

Basically copied the implementation for the error UI.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have reviewed any generated registry diagram changes

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 11, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b0c3600
Status: ✅  Deploy successful!
Preview URL: https://0bee723e.penrose-72l.pages.dev
Branch Preview URL: https://warnings.penrose-72l.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented May 11, 2023

± Registry diff

📊 Performance

Key

Note that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.

     0s   1s   2s   3s   4s   5s   6s   7s   8s   9s
     |    |    |    |    |    |    |    |    |    |
name ▝▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▞▀▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▖
      compilation labelling optimization rendering

Data

                                                                  0s   1s   2s   3s   4s   5s   6s
                                                                  |    |    |    |    |    |    |
3d-projection-fake-3d-linear-algebra                              ▝▞▖
acquaintanceship-graph-simple-graph                               ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚▀▀▀▀▀▀▚
allShapes-allShapes                                               ▝▞▄
angle-equivalence-triangle-mesh-2d                                ▝▀▚▀▀▖
arrowheads-arrowheads                                             ▝▞▖
caffeine-structural-formula                                       ▝▀▀▚▚
call-directed-graph-directed-multigraph                           ▝▀▀▀▀▀▚▀▀▚
call-undirected-graph-pseudograph                                 ▝▀▀▀▀▞▚
center-shrink-circle-animation                                    ▝▞▖
circle-example-euclidean                                          ▝▀▞▖
closest-point-test-closest-point                                  ▝▀▀▀▀▀▀▞▖
collinear-euclidean                                               ▝▀▞▖
communications-network-one-way-links-graph-simple-directed-graph  ▝▀▀▀▀▚▀▖
complete-bipartite-graphs-simple-graph                            ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▞▀▀▚
complete-graphs-simple-graph                                      ▝▀▀▀▀▀▀▀▀▀▚▀▀▖
computer-network-diagnostic-links-graph-pseudograph               ▝▀▀▀▀▞▖
computer-network-graph-simple-graph                               ▝▀▀▚▚
computer-network-multiple-links-graph-pseudograph                 ▝▀▀▀▀▞▀▖
computer-network-multiple-one-way-links-graph-directed-multigraph ▝▀▀▀▀▀▀▞▀▖
concyclic-pair-triangle-mesh-2d                                   ▝▀▞▖
congruent-triangles-euclidean                                     ▝▀▀▞▖
continuousmap-continuousmap                                       ▝▚▚
cotan-formula-triangle-mesh-2d                                    ▝▀▞▖
cube-graphs-simple-graph                                          ▝▀▀▀▀▀▀▀▀▀▚▀▚
cubic-bezier-cubic-bezier                                         ▝▚▀▚
cycle-graphs-simple-graph                                         ▝▀▀▀▀▀▚▀▚
glutamine-molecules-basic                                         ▝▀▞▖
half-adder-distinctive-shape                                      ▝▚▚
halfedge-mesh-triangle-mesh-2d                                    ▝▀▞▖
hybrid-topology-graph-simple-graph                                ▝▀▚▚
hypercube-network-graph-simple-graph                              ▝▀▀▀▚▚
hypergraph-hypergraph                                             ▝▀▀▀▞▀▀▀▀▀▀▀▀▖
incenter-triangle-euclidean                                       ▝▀▞▖
influence-graph-simple-directed-graph                             ▝▀▚▚
jobs-trained-matching-graph-simple-graph                          ▝▀▀▀▞▚
jobs-trained-no-matching-graph-simple-graph                       ▝▀▀▚▚
lagrange-bases-lagrange-bases                                     ▝▞▖
linear-array-graph-simple-graph                                   ▝▀▚▚
lines-around-rect-rect-line-dist                                  ▝▚▚
matrix-matrix-addition-matrix-ops                                 ▝▚▚
matrix-matrix-division-elementwise-matrix-ops                     ▝▚▚
matrix-matrix-multiplication-elementwise-matrix-ops               ▝▚▚
matrix-matrix-multiplication-matrix-ops                           ▝▚▚
matrix-matrix-subtraction-matrix-ops                              ▝▚▚
matrix-transpose-matrix-ops                                       ▝▚▚
matrix-vector-left-multiplication-matrix-ops                      ▝▚▚
matrix-vector-right-multiplication-matrix-ops                     ▝▀▞▖
mesh-network-graph-simple-graph                                   ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▞▀▀▀▀▀▀▀▀▀▀▖
midsegment-triangles-euclidean                                    ▝▀▞▖
mobius-mobius                                                     ▝▞▖
module-dependency-graph-simple-directed-graph                     ▝▀▀▀▞▚
niche-overlap-graph-simple-graph                                  ▝▀▀▀▀▚▚
nitricacid-lewis                                                  ▝▀▀▞▀▖
non-convex-non-convex                                             ▝▚▚
one-water-molecule-atoms-and-bonds                                ▝▞▖
parallel-lines-euclidean                                          ▝▀▞▖
persistent-homology-persistent-homology                           ▝▀▀▞▀▀▀▀▀▀▀▚▖
points-around-line-shape-distance                                 ▝▀▀▚▚
points-around-polyline-shape-distance                             ▝▀▀▞▖
points-around-star-shape-distance                                 ▝▀▀▀▞▖
precedence-graph-simple-directed-graph                            ▝▀▀▚▚
protein-interaction-graph-simple-graph                            ▝▀▀▀▀▀▀▞▀▀▖
quaternion-group-group-theory-cayley-graph                        ▝▀▚▚
quaternion-group-group-theory-multiplication-table                ▝▀▀▀▄▞▖
relative-orientation-triangle-mesh-2d                             ▝▚▚
ring-topology-graph-simple-graph                                  ▝▀▞▖
round-robin-graph-simple-directed-graph                           ▝▀▀▀▀▞▖
scalar-vector-division-matrix-ops                                 ▝▚▚
scalar-vector-left-multiplication-matrix-ops                      ▝▚▚
scalar-vector-right-multiplication-matrix-ops                     ▝▚▚
siggraph-teaser-euclidean-teaser                                  ▝▀▚▚
star-topology-graph-simple-graph                                  ▝▀▚▚
tree-tree                                                         ▝▀▄▚
tree-venn                                                         ▝▀▚▚
tree-venn-3d                                                      ▝▀▞▄▖
triangle-centers-triangle-mesh-2d                                 ▝▚▚
two-triangles-triangle-mesh-3d                                    ▝▚▚
two-vectors-perp-vectors-dashed                                   ▝▞▖
union-graph-simple-graph                                          ▝▀▀▞▖
vector-vector-addition-matrix-ops                                 ▝▚▚
vector-vector-division-elementwise-matrix-ops                     ▝▚▚
vector-vector-multiplication-elementwise-matrix-ops               ▝▚▚
vector-vector-outerproduct-matrix-ops                             ▝▚▚
vector-vector-subtraction-matrix-ops                              ▝▚▚
vector-wedge-exterior-algebra                                     ▝▞▖
wet-floor-atoms-and-bonds                                         ▝▚▀▚
wheel-graphs-simple-graph                                         ▝▀▀▀▀▀▀▀▀▀▞▀▚
word-cloud-example-word-cloud                                     ▝▀▞▖
wos-laplace-estimator-walk-on-spheres                             ▝▀▞▖
wos-nested-estimator-walk-on-spheres                              ▝▀▀▞▀▖
wos-offcenter-estimator-walk-on-spheres                           ▝▀▞▚
wos-poisson-estimator-walk-on-spheres                             ▝▀▞▚

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #1381 (b0c3600) into main (2ce26c2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1381   +/-   ##
=======================================
  Coverage   64.44%   64.44%           
=======================================
  Files          64       64           
  Lines        7481     7481           
  Branches     1782     1782           
=======================================
  Hits         4821     4821           
  Misses       2532     2532           
  Partials      128      128           
Impacted Files Coverage Δ
packages/core/src/index.ts 49.61% <ø> (ø)

Copy link
Collaborator

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks for finally doing this! Build is failing at the moment but once that's fixed, I'd say this is good to go.

packages/examples/src/group-theory/CayleyGraph.style Outdated Show resolved Hide resolved
@wodeni wodeni merged commit 31a59f9 into main May 11, 2023
10 checks passed
@wodeni wodeni deleted the warnings branch May 11, 2023 18:49
@samestep samestep mentioned this pull request May 12, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings don't show up in the IDE
2 participants