-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show warnings in editor
#1381
Conversation
Deploying with Cloudflare Pages
|
± Registry diff
📊 PerformanceKeyNote that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.
Data
|
Codecov Report
@@ Coverage Diff @@
## main #1381 +/- ##
=======================================
Coverage 64.44% 64.44%
=======================================
Files 64 64
Lines 7481 7481
Branches 1782 1782
=======================================
Hits 4821 4821
Misses 2532 2532
Partials 128 128
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks for finally doing this! Build is failing at the moment but once that's fixed, I'd say this is good to go.
Description
Resolves #1305.
This PR displays warnings in
editor
. The current implementation simply shows them in the diagram panel, just like errors but in a different color:Like shown in the screenshot, some of our gallery diagrams contain warnings (mostly
ImplicitOverrideWarning
).Implementation strategy and design decisions
Basically copied the implementation for the error UI.
Checklist