Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pull out base tsconfig.json #1392

Merged
merged 2 commits into from May 15, 2023
Merged

refactor: pull out base tsconfig.json #1392

merged 2 commits into from May 15, 2023

Conversation

samestep
Copy link
Collaborator

@samestep samestep commented May 15, 2023

Description

As suggested in #948 (comment), this PR pulls out shared stuff from all our tsconfig.json files (except @penrose/roger, because I'm waiting on #1387) into a repo root-level base tsconfig.json file. While doing this I also found a bunch of useless stuff that I got rid of.

Implementation strategy and design decisions

  • We don't use JSX in @penrose/automator, so I renamed index.ts to index.tsx.
  • I enabled noFallthroughCasesInSwitch globally, which caught a small sloppiness in @penrose/editor that I fixed.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have reviewed any generated registry diagram changes

Open questions

  • What's going on with the tsconfig.node.json files in @penrose/edgeworth and @penrose/editor?

@samestep samestep requested a review from wodeni May 15, 2023 19:36
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #1392 (6401fbf) into main (73664bf) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 6401fbf differs from pull request most recent head ee1d901. Consider uploading reports for the commit ee1d901 to get more accurate results

@@            Coverage Diff             @@
##             main    #1392      +/-   ##
==========================================
- Coverage   64.44%   64.43%   -0.01%     
==========================================
  Files          64       64              
  Lines        7554     7552       -2     
  Branches     1794     1794              
==========================================
- Hits         4868     4866       -2     
  Misses       2558     2558              
  Partials      128      128              

see 2 files with indirect coverage changes

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 15, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6401fbf
Status:🚫  Build failed.

View logs

@github-actions
Copy link

± Registry diff

📊 Performance

Key

Note that each bar component rounds up to the nearest 100ms, so each full bar is an overestimate by up to 400ms.

     0s   1s   2s   3s   4s   5s   6s   7s   8s   9s
     |    |    |    |    |    |    |    |    |    |
name ▝▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▞▀▀▀▀▀▀▀▀▀▀▀▀▚▄▄▄▄▄▄▄▄▄▖
      compilation labelling optimization rendering

Data

                                                                  0s   1s   2s   3s   4s   5s   6s   7s
                                                                  |    |    |    |    |    |    |    |
3d-projection-fake-3d-linear-algebra                              ▝▞▖
acquaintanceship-graph-simple-graph                               ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▞▀▀▀▀▀▀▀▚
allShapes-allShapes                                               ▝▚▚▄▄▄
angle-equivalence-triangle-mesh-2d                                ▝▀▀▀▞▀▀▖
arpanet-simple-curved-graph-dots                                  ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▚▀▀▀▀▀▀▀▀▀▚
arrowheads-arrowheads                                             ▝▚▚
caffeine-structural-formula                                       ▝▀▀▀▞▄
call-directed-graph-directed-multigraph                           ▝▀▀▀▀▀▀▀▞▀▀▚
call-undirected-graph-pseudograph                                 ▝▀▀▀▀▀▀▚▀▖
center-shrink-circle-animation                                    ▝▞▖
circle-example-euclidean                                          ▝▀▀▞▖
closest-point-test-closest-point                                  ▝▀▀▀▀▀▀▀▚▚
collinear-euclidean                                               ▝▀▀▞▖
communications-network-one-way-links-graph-simple-directed-graph  ▝▀▀▀▀▀▞▀▖
complete-bipartite-graphs-simple-graph                            ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▞▀▀▀▖
complete-graphs-simple-graph                                      ▝▀▀▀▀▀▀▀▀▀▀▚▀▀▚
computer-network-diagnostic-links-graph-pseudograph               ▝▀▀▀▀▀▞▚
computer-network-graph-simple-graph                               ▝▀▀▀▀▞▖
computer-network-multiple-links-graph-pseudograph                 ▝▀▀▀▀▚▀▀▖
computer-network-multiple-one-way-links-graph-directed-multigraph ▝▀▀▀▀▀▀▀▚▀▚
concyclic-pair-triangle-mesh-2d                                   ▝▀▚▚
congruent-triangles-euclidean                                     ▝▀▀▀▞▖
continuousmap-continuousmap                                       ▝▚▚
cotan-formula-triangle-mesh-2d                                    ▝▀▀▞▚
cube-graphs-simple-graph                                          ▝▀▀▀▀▀▀▀▀▀▀▀▀▚▀▚
cubic-bezier-closed-elastic-curve                                 ▝▀▀▞▀▚
cubic-bezier-cubic-bezier                                         ▝▀▞▀▚
cubic-bezier-open-elastic-curve                                   ▝▀▀▞▀▖
cycle-graphs-simple-graph                                         ▝▀▀▀▀▀▀▀▞▀▚
glutamine-molecules-basic                                         ▝▀▚▚
half-adder-distinctive-shape                                      ▝▀▞▖
halfedge-mesh-triangle-mesh-2d                                    ▝▀▚▚
hybrid-topology-graph-simple-graph                                ▝▀▀▚▚
hypercube-network-graph-simple-graph                              ▝▀▀▀▀▀▀▞▖
hypergraph-hypergraph                                             ▝▀▀▀▀▞▀▀▀▀▀▀▀▀▀▚
incenter-triangle-euclidean                                       ▝▀▀▞▖
influence-graph-simple-directed-graph                             ▝▀▀▞▖
jobs-trained-matching-graph-simple-graph                          ▝▀▀▀▀▞▚
jobs-trained-no-matching-graph-simple-graph                       ▝▀▀▀▀▞▚
lagrange-bases-lagrange-bases                                     ▝▚▚
linear-array-graph-simple-graph                                   ▝▀▀▀▞▖
lines-around-rect-rect-line-dist                                  ▝▚▚
matrix-matrix-addition-matrix-ops                                 ▝▀▞▖
matrix-matrix-division-elementwise-matrix-ops                     ▝▀▞▖
matrix-matrix-multiplication-elementwise-matrix-ops               ▝▀▞▖
matrix-matrix-multiplication-matrix-ops                           ▝▀▞▖
matrix-matrix-subtraction-matrix-ops                              ▝▀▞▖
matrix-transpose-matrix-ops                                       ▝▀▞▖
matrix-vector-left-multiplication-matrix-ops                      ▝▀▚▚
matrix-vector-right-multiplication-matrix-ops                     ▝▀▞▖
mesh-network-graph-simple-graph                                   ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▞▀▀▀▀▀▀▀▀▀▀▀▀▚
midsegment-triangles-euclidean                                    ▝▀▀▞▖
mobius-mobius                                                     ▝▚▚
module-dependency-graph-simple-directed-graph                     ▝▀▀▀▀▚▀▖
niche-overlap-graph-simple-graph                                  ▝▀▀▀▀▀▚▚
nitricacid-lewis                                                  ▝▀▀▀▞▀▚
non-convex-non-convex                                             ▝▀▞▖
nyc-subway-simple-curved-graph-boxes                              ▝▀▀▀▀▀▀▀▀▞▀▀▀▚
one-water-molecule-atoms-and-bonds                                ▝▞▖
parallel-lines-euclidean                                          ▝▀▀▞▖
persistent-homology-persistent-homology                           ▝▀▀▀▞▀▀▀▀▀▀▀▀▀▚▖
points-around-line-shape-distance                                 ▝▀▀▞▖
points-around-polyline-shape-distance                             ▝▀▀▚▚
points-around-star-shape-distance                                 ▝▀▀▀▀▞▖
precedence-graph-simple-directed-graph                            ▝▀▀▀▚▚
protein-interaction-graph-simple-graph                            ▝▀▀▀▀▀▀▀▚▀▀▀▖
quaternion-group-group-theory-cayley-graph                        ▝▀▀▞▖
quaternion-group-group-theory-multiplication-table                ▝▀▀▀▚▄▚▖
relative-orientation-triangle-mesh-2d                             ▝▀▚▚
ring-topology-graph-simple-graph                                  ▝▀▚▚
round-robin-graph-simple-directed-graph                           ▝▀▀▀▀▀▞▚
scalar-vector-division-matrix-ops                                 ▝▀▞▖
scalar-vector-left-multiplication-matrix-ops                      ▝▀▞▖
scalar-vector-right-multiplication-matrix-ops                     ▝▚▚
sec5-ex32-simple-curved-graph                                     ▝▀▀▀▀▀▀▀▚▀▀▀▀▀▀▖
siggraph-teaser-euclidean-teaser                                  ▝▀▀▚▚
star-topology-graph-simple-graph                                  ▝▀▀▞▖
tree-tree                                                         ▝▀▚▚
tree-venn                                                         ▝▀▀▞▖
tree-venn-3d                                                      ▝▀▞▄▄
triangle-centers-triangle-mesh-2d                                 ▝▀▞▖
two-triangles-triangle-mesh-3d                                    ▝▚▚
two-vectors-perp-vectors-dashed                                   ▝▚▚
union-graph-simple-graph                                          ▝▀▀▀▚▚
vector-vector-addition-matrix-ops                                 ▝▚▚
vector-vector-division-elementwise-matrix-ops                     ▝▚▚
vector-vector-multiplication-elementwise-matrix-ops               ▝▀▞▖
vector-vector-outerproduct-matrix-ops                             ▝▚▚
vector-vector-subtraction-matrix-ops                              ▝▚▚
vector-wedge-exterior-algebra                                     ▝▚▚
wet-floor-atoms-and-bonds                                         ▝▀▞▀▖
wheel-graphs-simple-graph                                         ▝▀▀▀▀▀▀▀▀▀▀▀▀▀▞▀▀▖
word-cloud-example-word-cloud                                     ▝▀▞▖
wos-laplace-estimator-walk-on-spheres                             ▝▀▚▚
wos-nested-estimator-walk-on-spheres                              ▝▀▀▚▀▀▖
wos-offcenter-estimator-walk-on-spheres                           ▝▀▀▞▀▖
wos-poisson-estimator-walk-on-spheres                             ▝▀▚▀▚

@samestep samestep merged commit e6c5f55 into main May 15, 2023
9 of 10 checks passed
@samestep samestep deleted the tsconfig-base branch May 15, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants